Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 upgrade clarification #226

Open
richardonrails opened this issue Sep 23, 2022 · 1 comment
Open

Rails 7 upgrade clarification #226

richardonrails opened this issue Sep 23, 2022 · 1 comment
Labels

Comments

@richardonrails
Copy link

I'm currently on Rails 6.1 and devise-two-factor 4.0.2

I see what looks like a bit of contradiction in your docs:

https://github.com/tinfoil/devise-two-factor/blob/main/CHANGELOG.md#402 says that 4.0.2 "Adds Rails 7.0 support"

But then https://github.com/tinfoil/devise-two-factor/blob/main/UPGRADING.md#upgrading-from-4x-to-5x says "This gem must be upgraded as part of a Rails 7 upgrade"

So which is it -- can I upgrade to Rails 7 while staying on 4.0.2 at first? Or do I need to upgrade both at the same time?

@adamzapasnik
Copy link

you can upgrade to rails 7 without upgrading this gem to 5.x, just use this attr_encrypted's fork https://github.com/PagerTree/attr_encrypted/commits/rails-7-0-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants