Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker improvements #17

Open
raveclassic opened this issue Oct 3, 2016 · 0 comments
Open

DatePicker improvements #17

raveclassic opened this issue Oct 3, 2016 · 0 comments

Comments

@raveclassic
Copy link
Member

This is a copy.

  • get rid of moment.js and ISO-strings, use native Date type
  • and use standard (or polyfill), see related:
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat and https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString
  • replace onmousedown with onclick, don't block input blur
  • remove imperative props methods from DateInput ('openDatePicker', 'closeDatePicker') - isOpened state should be handled on DatePicker level, not on Input's
  • DateInput should not be responsible for any kind of formatting, consider using plain Input (see SymbolSuggest)
  • do not use calendarTheme prop - it breaks pure-rendering
  • rename fieldComponent to Input
  • use formatter functions instead of format strings for moment
  • do not handle validation
  • remove all explicit sizes from dx-components css (paddings, margins, widths etc.)
  • do not handle state in Calendar (move to datepicker)
  • moment.clone() seems to break pure-rendering everywhere
  • research react perf
  • render calendar/month as css-table
  • accept all child component classes as props (research DI)
@raveclassic raveclassic self-assigned this Oct 3, 2016
@raveclassic raveclassic removed their assignment Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant