Add support for ethers v6 in @typechain/hardhat #843
Conversation
🦋 Changeset detectedLatest commit: 137ebd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
These are no longer peer deps in target-ethers-v6
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @nomiclabs/hardhat-ethers@2.0.5, @nomiclabs/hardhat-waffle@2.0.3 |
|
I tested this more and pushed some fixes. It would be great if you could get this merged and released soon, so we can release a new version of our Toolbox with proper Typechain support for ethers v6 ❤️ |
| @@ -14,7 +14,7 @@ | |||
| "@nomiclabs/hardhat-etherscan": "^2.1.1", | |||
| "@nomiclabs/hardhat-truffle5": "^2.0.0", | |||
| "@nomiclabs/hardhat-web3": "^2.0.0", | |||
| "@typechain/hardhat": "workspace:^7.0.0", | |||
| "@typechain/hardhat": "workspace:^8.0.0", | |||
There was a problem hiding this comment.
My bad, this is a leftover of when I was trying things locally with verdaccio. I'll undo it.
There was a problem hiding this comment.
@fvictorio note i fixed this and all other issues in: #845
| > extends Event { | ||
| args: TArgsArray & TArgsObject; | ||
| } | ||
| /* Autogenerated file. Do not edit manually. */ |
There was a problem hiding this comment.
I think thit is a slight bug in ethers-v6 target that causes double preamble. Wanna have a look?
Closes #842.
Tentative changes. I tried this locally and seems to work.
Something I don't like about my implementation is that the contract-specific types for
deployContractdon't have the right constructor parameters types. I'm not sure how to do this properly, but it seems to me thatgenerateHardhatHelpershould receive more information about the contracts to be able to do that, and not just the names.I also changed some docs to use our chai matchers instead of waffle, since that's the approach we recommend, and because the chai matchers will have support for ethers v6 (and waffle doesn't yet afaik).