From a4d8c796fa0e5fec8fa27f2779a213c1680ace9b Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Sun, 16 Oct 2022 16:35:53 +0100 Subject: [PATCH 1/2] Deprecate `TrailingComma` as it's now split in two rules --- detekt-core/src/main/resources/deprecation.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/detekt-core/src/main/resources/deprecation.properties b/detekt-core/src/main/resources/deprecation.properties index 6fcf5c93d11..c1ca138175b 100644 --- a/detekt-core/src/main/resources/deprecation.properties +++ b/detekt-core/src/main/resources/deprecation.properties @@ -13,6 +13,7 @@ style>UnnecessaryAbstractClass>excludeAnnotatedClasses=Use `ignoreAnnotated` ins style>UseDataClass>excludeAnnotatedClasses=Use `ignoreAnnotated` instead formatting>Indentation>continuationIndentSize=`continuationIndentSize` is ignored by KtLint and will have no effect formatting>ParameterListWrapping>indentSize=`indentSize` is ignored by KtLint and will have no effect +formatting>TrailingComma=Rule is split between `TrailingCommaOnCallSite` and `TrailingCommaOnDeclarationSite` now. style>ForbiddenPublicDataClass=Rule migrated to `libraries` ruleset plugin style>LibraryCodeMustSpecifyReturnType=Rule migrated to `libraries` ruleset plugin style>LibraryEntitiesShouldNotBePublic=Rule migrated to `libraries` ruleset plugin From 4b561d5cd73942eb54d1f0e5e7674b8cea47345a Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 21 Oct 2022 17:08:39 +0100 Subject: [PATCH 2/2] Add deprecation to DeprecatedPrinter --- .../arturbosch/detekt/generator/printer/DeprecatedPrinter.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/DeprecatedPrinter.kt b/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/DeprecatedPrinter.kt index 1acf5bf9ff7..c9b07811f09 100644 --- a/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/DeprecatedPrinter.kt +++ b/detekt-generator/src/main/kotlin/io/gitlab/arturbosch/detekt/generator/printer/DeprecatedPrinter.kt @@ -37,6 +37,7 @@ private fun writeProperty(ruleSet: RuleSetPage, rule: Rule, configuration: Confi internal fun writeMigratedRules(): String { return """ + formatting>TrailingComma=Rule is split between `TrailingCommaOnCallSite` and `TrailingCommaOnDeclarationSite` now. style>ForbiddenPublicDataClass=Rule migrated to `libraries` ruleset plugin style>LibraryCodeMustSpecifyReturnType=Rule migrated to `libraries` ruleset plugin style>LibraryEntitiesShouldNotBePublic=Rule migrated to `libraries` ruleset plugin