New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ending line and column to Location.kt #5032
Conversation
d13d9a0
to
dacb224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is it necessary to change the name of parameters, for example
startSource
andendSource
?
I don't think so. That would introduce even more breaking changes in the api for little benefit.
- Should the order of the parameters be changed?
That's up to you. You will need to create a new constructor matching the old one to avoid breaking the api so it's OK don't add it as the first one.
- Should
compact()
string representation be updated?
No
- Should there be a test for such trivia?
I don't think so. You are just adding a parameter.
But I would change the code inside core to inform this new value in this same pr. This way we can see that this is the change that we need.
detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/Location.kt
Outdated
Show resolved
Hide resolved
Hey @BraisGabin Thanks for clarifying things. |
Sorry, I'm afraid I didn't get it. What core are you talking about? |
I was on my mobile and clearly I dind't explain myself. You are adding the ability to store endSource inside Open question, mainly for maintainers. What do you think about a
|
Now I see. |
Thanks :) this looks great |
👍 |
Close #5025
Added
endSource
as the last parameter in theLocation
constructor.I need some guidelines:
startSource
andendSource
?compact()
string representation be updated?This could trigger changes in many files.