Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale bot is a bit aggressive #5520

Closed
3flex opened this issue Nov 9, 2022 · 3 comments
Closed

Stale bot is a bit aggressive #5520

3flex opened this issue Nov 9, 2022 · 3 comments

Comments

@3flex
Copy link
Member

3flex commented Nov 9, 2022

Expected Behavior

Issues shouldn't always be auto closed just because they haven't been interacted with in a while.

Observed Behavior

Issues are marked for closure after 90 days, then closed a week later. Some valid issues are being closed, and it creates noise for anyone who left a comment or subscribed to updates.

Steps to Reproduce

Context

I think stale bot should only auto close:

  • PRs if there is no recent activity, possibly with a shorter threshold
  • Issues, but only those tagged with "waiting for feedback" that have been open more than a certain time. 30 days might be more appropriate here.

Your Environment

  • Version of detekt used:
  • Version of Gradle used (if applicable):
  • Gradle scan link (add --scan option when running the gradle task):
  • Operating System and version:
  • Link to your project (if it's a public repository):
@BraisGabin
Copy link
Member

I don't think it is too aggressive. 3 months without an update is usually means that the issue is not actionable. I would also like to know how much issues was closed but stale bot. I think they were not too much.

I feel like stale bot force us to take a decision over those type of issues? Can we actionate it? Is clear enoght for any one to pick it up? We end up taking the decission of adding a tag to avoid the stealing (for example help wanting) or taking the decission to close the issue ourself before the 7 days period.

And even if stale bot ends up closing an issue there is nothing preventing us to reopen the issue of we really think that it is worth it.

@BraisGabin
Copy link
Member

Issues, but only those tagged with "waiting for feedback" that have been open more than a certain time. 30 days might be more appropriate here.

I also though about this. The waiting for feedback issues should stale faster.

@cortinico
Copy link
Member

I don't think it is too aggressive.

Same. I actually believe the value it brings is net positive. I agree that some valuable issues might be closed, but so far it also helped us bring attention and solve issues that we forgot to follow up with.

The waiting for feedback issues should stale faster.

Agree. I've sent this one here:

@3flex 3flex closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants