Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: The set-output and save-state command is deprecated and will be disabled soon. #5432

Closed
TWiStErRob opened this issue Oct 17, 2022 · 7 comments
Labels

Comments

@TWiStErRob
Copy link
Member

TWiStErRob commented Oct 17, 2022

Expected Behavior

No warnings.

Observed Behavior

113 warnings on PR CI.
image

Steps to Reproduce

See recent CI job, e.g. https://github.com/detekt/detekt/actions/runs/3261225698

Context

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
 

@TWiStErRob TWiStErRob added the bug label Oct 17, 2022
@3flex
Copy link
Member

3flex commented Oct 17, 2022

Thanks for raising this - these are triggered by third party actions (such as gradle-build-action), so as they get updated, this will resolve itself.

@3flex 3flex added ci and removed bug labels Oct 17, 2022
@TWiStErRob
Copy link
Member Author

TWiStErRob commented Oct 18, 2022

I did a bit of investigation to see which ones are the interesting actions:

  • website.yml (example https://github.com/detekt/detekt/actions/runs/3261225698/jobs/5355677542)
    • actions/checkout (3)
    • actions/setup-java (3)
    • gradle/gradle-build-action (6)
  • pre-merge.yml (example https://github.com/detekt/detekt/actions/runs/3266022234)
    • verify-generated-config-file (10)
      • actions/checkout (3)
      • actions/setup-java (3)
      • gradle/gradle-build-action (4)
    • compile-test-snippets (10)
      • actions/checkout (3)
      • actions/setup-java (3)
      • gradle/gradle-build-action (4)
    • warnings-as-errors (10)
      • actions/checkout (3)
      • actions/setup-java (3)
      • gradle/gradle-build-action (4)
    • gradle (matrix: 11 * 8 ~ 88)
      • actions/checkout (3)
      • actions/setup-java (3)
      • gradle/gradle-build-action (5)

and to make sure that the third parties are making progress on this:

@TWiStErRob
Copy link
Member Author

@detekt please press the first checkbox at #4298:

Update actions/checkout digest to 93ea575

(this is according to Renovate guru.)

@BraisGabin
Copy link
Member

Done

@BraisGabin
Copy link
Member

@TWiStErRob so now we are just waiting for gradle/gradle-build-action, right?

@TWiStErRob
Copy link
Member Author

Yeah, seems so, 0 activity so far. They have tons of dependency update PRs open, so I think it's abandoned.

@TWiStErRob
Copy link
Member Author

TWiStErRob commented Oct 21, 2022

They fixed it as well, not released yet. I'm watching for releases will update once I get the email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants