Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ktlint and switch to the non-experimental TrailingCommaOnCallSiteRule & TrailingCommaOnDeclarationSiteRule #5365

Closed
Hexcles opened this issue Sep 29, 2022 · 1 comment
Labels

Comments

@Hexcles
Copy link
Contributor

Hexcles commented Sep 29, 2022

ktlint has graduated TrailingCommaRule from experimental to standard ruleset, while splitting it into two rules: TrailingCommaOnCallSiteRule & TrailingCommaOnDeclarationSiteRule.

There is a practical benefit for having them separate, as you'll be able to enforce one kind while ignoring the other (in a sense, making the current settings for TrailingComma "nullable", which can, for example, help to work around issues like pinterest/ktlint#1557 by opting out of TrailingCommaOnCallSiteRule while still keeping TrailingCommaOnDeclarationSiteRule.

@3flex
Copy link
Member

3flex commented Sep 30, 2022

Thanks for raising! I'm closing as this is effectively a duplicate of #5281, and will be addressed by #5312 which should hopefully be included in the final 1.22.0 detekt release.

@3flex 3flex closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants