Add MaxChainedCallsOnSameLine style rule #4985
Conversation
Add a new rule MaxChainedCallsOnSameLine to limit the number of chained calls on placed on a single line. This works well alongside CascadingCallWrapping in #4979 to make long call chains more readable by wrapping them on new lines.
| ) | ||
|
|
||
| @Configuration("maximum chained calls allowed on a single line") | ||
| private val maxChainedCalls: Int by config(defaultValue = 5) |
There was a problem hiding this comment.
🤔 Isn't 5 far too much? I would say 3 or 4. But this is really subjective.
There was a problem hiding this comment.
I was leaning toward making it more conservative, since in my experience it's not uncommon to have calls on e.g. network models that can be at least a few references deep. But I don't feel strongly; happy to change to any other value.
|
Again, great rule :) |
I agree in practice it contributes to the complexity of a line in the same way; I didn't include just since it seemed more likely to be unintuitive. Also more than happy to add it if others have thoughts, or include it as a configuration parameter (but that's likely to overcomplicate it as well). |
|
I approve this PR but I would like to know what others think about the default value. I feel it should be lowered a bit but I would like to have more opinions here. |
I think 5 is a good number. Don't have a strong opinion. As the rule is disabled by default, users can easily customize it once they enable it |
Add a new rule MaxChainedCallsOnSameLine to limit the number of chained calls on placed on a single line. This works well alongside CascadingCallWrapping in #4979 to make long call chains more readable by wrapping them on new lines.