Replies: 1 comment 3 replies
-
I completely agree with this. I don't want all my compilation to be detekt-ready. Even on detekt we don't want them to be warning-free. For that reason we only enable this flag on CI instead of having it enable by default: detekt/.github/workflows/pre-merge.yaml Line 103 in e41f9f2 I can't talk to loud here because I didn't test the compiler plugin yet and I'm not 100% sure how it works. But in my daily builds I don't want to have the detekt plugin enabled. I want really fast compilations. The compiler plugin makes detekt way faster. But don't run detekt is even faster. So it would be nice to be able to have the plugin disable by default and only enable it when you really want detekt to pass (pre-commit, pre-push, pre-merge...). As I said, maybe all of this is doable right now, I have no idea. About when to raise the errors: On detekt 1.x I think it will be really difficult to archive that. I raised this proposal for detekt 2.0: #6085. It should allow to do what you are asking for. |
Beta Was this translation helpful? Give feedback.
-
I've just heard about the upcoming compiler plugin and from what I understand, the plugin will analyze and fail the compilation completely if detekt issues are detected. I see two problems with that:
What if compiler plugin would just write report files, but not actually fail the build? Then something like
analyzeDetektReport
task could be made that would read the reports and fail with the console output (similar to howdetekt
task fails now).Beta Was this translation helpful? Give feedback.
All reactions