From 03807166491c4d93943373cd3273684c9e4d8b66 Mon Sep 17 00:00:00 2001
From: Nicola Corti <corti.nico@gmail.com>
Date: Mon, 25 Apr 2022 02:24:45 +0100
Subject: [PATCH] Move detekt-gradle-plugin to be a composite build (#4751)

---
 .github/workflows/pre-merge.yaml                 | 2 +-
 build-logic/src/main/kotlin/releasing.gradle.kts | 8 --------
 build.gradle.kts                                 | 6 +++++-
 detekt-gradle-plugin/build.gradle.kts            | 7 +++----
 gradle/libs.versions.toml                        | 1 -
 scripts/release.sh                               | 2 +-
 settings.gradle.kts                              | 2 +-
 7 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/pre-merge.yaml b/.github/workflows/pre-merge.yaml
index 4c6018b6b1d..d4405ed279e 100644
--- a/.github/workflows/pre-merge.yaml
+++ b/.github/workflows/pre-merge.yaml
@@ -82,4 +82,4 @@ jobs:
       - name: Build and compile test snippets
         uses: gradle/gradle-build-action@v2
         with:
-          arguments: test -x :detekt-gradle-plugin:test -Pcompile-test-snippets=true
+          arguments: test -Pcompile-test-snippets=true
diff --git a/build-logic/src/main/kotlin/releasing.gradle.kts b/build-logic/src/main/kotlin/releasing.gradle.kts
index 2a10a5d0549..0a38fb6e322 100644
--- a/build-logic/src/main/kotlin/releasing.gradle.kts
+++ b/build-logic/src/main/kotlin/releasing.gradle.kts
@@ -69,12 +69,4 @@ tasks {
         linePartToFind.set("    detektVersion:")
         lineTransformation.set("    detektVersion: '${Versions.DETEKT}'")
     }
-
-    register<UpdateVersionInFileTask>("applySelfAnalysisVersion") {
-        fileToUpdate.set(file("${rootProject.rootDir}/gradle/libs.versions.toml"))
-        linePartToFind.set("detekt = { id = \"io.gitlab.arturbosch.detekt\"")
-        lineTransformation.set(
-            "detekt = { id = \"io.gitlab.arturbosch.detekt\", version = \"${Versions.DETEKT}\" }"
-        )
-    }
 }
diff --git a/build.gradle.kts b/build.gradle.kts
index 3f14edd2b5d..588ef8ee389 100644
--- a/build.gradle.kts
+++ b/build.gradle.kts
@@ -3,7 +3,7 @@ import io.gitlab.arturbosch.detekt.DetektCreateBaselineTask
 
 plugins {
     id("releasing")
-    alias(libs.plugins.detekt)
+    id("io.gitlab.arturbosch.detekt")
     alias(libs.plugins.gradleVersions)
     alias(libs.plugins.sonarqube)
 }
@@ -105,3 +105,7 @@ val detektProjectBaseline by tasks.registering(DetektCreateBaselineTask::class)
     exclude(buildFiles)
     baseline.set(baselineFile)
 }
+
+tasks.register("build") {
+    dependsOn(gradle.includedBuild("detekt-gradle-plugin").task(":build"))
+}
diff --git a/detekt-gradle-plugin/build.gradle.kts b/detekt-gradle-plugin/build.gradle.kts
index c1818c6d9b0..c7093a15419 100644
--- a/detekt-gradle-plugin/build.gradle.kts
+++ b/detekt-gradle-plugin/build.gradle.kts
@@ -9,15 +9,14 @@ plugins {
     alias(libs.plugins.pluginPublishing)
 }
 
-detekt {
-    source.from("src/functionalTest/kotlin")
-}
-
 repositories {
     mavenCentral()
     google()
 }
 
+group = "io.gitlab.arturbosch.detekt"
+version = Versions.currentOrSnapshot()
+
 testing {
     suites {
         getByName("test", JvmTestSuite::class) {
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 98f88141445..999f36fa758 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -39,7 +39,6 @@ jcommander = "com.beust:jcommander:1.82"
 
 [plugins]
 binaryCompatibilityValidator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version = "0.9.0" }
-detekt = { id = "io.gitlab.arturbosch.detekt", version = "1.20.0" }
 dokka = { id = "org.jetbrains.dokka", version.ref = "dokka" }
 gradleVersions = { id = "com.github.ben-manes.versions", version = "0.42.0" }
 pluginPublishing = { id = "com.gradle.plugin-publish", version = "0.21.0" }
diff --git a/scripts/release.sh b/scripts/release.sh
index 82e5545ac0a..c7eebb2e26d 100755
--- a/scripts/release.sh
+++ b/scripts/release.sh
@@ -4,5 +4,5 @@ gradle build || exit
 gradle publishAllPublicationsToMavenCentralRepository --max-workers 1 || exit
 gradle publishPlugins -DautomatePublishing=true || exit
 gradle githubRelease || exit
-gradle applyDocVersion applySelfAnalysisVersion || exit
+gradle applyDocVersion || exit
 gradle closeAndReleaseRepository || exit
diff --git a/settings.gradle.kts b/settings.gradle.kts
index 4d8e46b4e23..e8e9e565939 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -4,6 +4,7 @@ rootProject.name = "detekt"
 
 pluginManagement {
     includeBuild("build-logic")
+    includeBuild("detekt-gradle-plugin")
 }
 
 include("code-coverage-report")
@@ -12,7 +13,6 @@ include("detekt-cli")
 include("detekt-core")
 include("detekt-formatting")
 include("detekt-generator")
-include("detekt-gradle-plugin")
 include("detekt-metrics")
 include("detekt-parser")
 include("detekt-psi-utils")