-
-
Notifications
You must be signed in to change notification settings - Fork 757
/
ObjectLiteralToLambdaSpec.kt
592 lines (537 loc) · 18.6 KB
/
ObjectLiteralToLambdaSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
package io.gitlab.arturbosch.detekt.rules.style
import io.gitlab.arturbosch.detekt.api.SourceLocation
import io.gitlab.arturbosch.detekt.rules.KotlinCoreEnvironmentTest
import io.gitlab.arturbosch.detekt.test.assert
import io.gitlab.arturbosch.detekt.test.compileAndLint
import io.gitlab.arturbosch.detekt.test.compileAndLintWithContext
import io.gitlab.arturbosch.detekt.test.lintWithContext
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
class ObjectLiteralToLambdaSpec {
val subject = ObjectLiteralToLambda()
@Nested
@KotlinCoreEnvironmentTest
inner class WithDefaultSources(val env: KotlinCoreEnvironment) {
@Nested
inner class `report convertible expression` {
@Test
fun `is property`() {
val code = """
fun interface Sam {
fun foo()
}
val a = object : Sam {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(4, 9))
}
@Test
fun `is in function`() {
val code = """
fun interface Sam {
fun foo()
}
fun bar() {
object : Sam {
override fun foo() {
}
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(5, 5))
}
@Test
fun `is in init`() {
val code = """
fun interface Sam {
fun foo()
}
object B {
init {
object : Sam {
override fun foo() {
}
}
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(6, 9))
}
@Test
fun `is generic`() {
val code = """
fun interface Sam<T> {
fun foo(): T
}
val a = object : Sam<Int> {
override fun foo(): Int {
return 1
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(4, 9))
}
@Test
fun `has other default method`() {
val code = """
fun interface Sam {
fun foo()
fun bar() {}
}
val a = object : Sam {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(5, 9))
}
@Test
fun `nested declaration`() {
val code = """
interface First {
fun foo()
}
fun interface Second: First
fun bar() {
object : Second {
override fun foo(){
}
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(7, 5))
}
@Test
fun `expression body syntax`() {
val code = """
fun interface Sam {
fun foo(): Int
}
val a = object : Sam {
override fun foo() = 3
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(4, 9))
}
}
@Nested
inner class `is not correct implement` {
@Test
fun `without type resolution`() {
val code = """
fun interface Sam {
fun foo()
}
val a = object : Sam {
override fun foo() {
}
}
"""
subject.compileAndLint(code).assert().isEmpty()
}
@Test
fun `is empty interface`() {
val code = """
interface Sam
val a = object : Sam {}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is empty interface and has own function`() {
val code = """
interface Sam
val a = object : Sam {
fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is single property interface`() {
val code = """
interface Sam {
val foo: Int
}
val a = object : Sam {
override val foo = 1
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is empty interface and has own property`() {
val code = """
interface Sam
val a = object : Sam {
val b = 1
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is not fun interface`() {
val code = """
interface Sam {
fun foo()
}
val a = object : Sam {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is not interface`() {
val code = """
abstract class Something {
abstract fun foo()
}
val a = object : Something() {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `has multi implement`() {
val code = """
fun interface First {
fun foo()
}
interface Second
val a: First = object : First, Second {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `has complex implement`() {
val code = """
abstract class First {
abstract fun foo()
}
fun interface Second {
fun foo()
}
val a: First = object : First(), Second {
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
}
@Nested
inner class `has impurities` {
@Test
fun `has more than one method`() {
val code = """
fun interface Sam {
fun foo()
}
val a = object : Sam {
override fun foo() {
}
fun bar() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `has property`() {
val code = """
fun interface Sam {
fun foo()
}
val a = object : Sam {
private var bar = 0
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `has init`() {
val code = """
fun interface Sam {
fun foo()
}
val a = object : Sam {
init {
}
override fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
}
@Nested
inner class `java interface` {
@Test
fun `is convertible`() {
val code = """
val a = object : Runnable {
override fun run(){
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(1, 9))
}
@Test
fun `is convertible Callable generic`() {
val code = """
import java.util.concurrent.Callable
val a = object : Callable<Int> {
override fun call(): Int {
return 1
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(2, 9))
}
@Test
fun `empty interface`() {
val code = """
import java.util.EventListener
val a = object : EventListener {
fun foo() {
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `is convertible Enumeration generic`() {
val code = """
import java.util.Enumeration
val a = object : Enumeration<Int> {
override fun hasMoreElements(): Boolean {
return true
}
override fun nextElement(): Int {
return 1
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
}
@Nested
inner class `object use itself` {
@Test
fun `call 'this'`() {
val code = """
fun interface Sam {
fun foo()
}
fun aa() {
object : Sam {
override fun foo() {
this
}
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `use 'this'`() {
val code = """
fun interface Sam {
fun foo()
}
fun Sam.bar() {}
fun aa() {
object : Sam {
override fun foo() {
bar()
}
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `use class method`() {
val code = """
fun interface Sam {
fun foo()
}
fun aa() {
object : Sam {
override fun foo() {
hashCode()
}
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
@Test
fun `call 'this' inside nested object`() {
val code = """
fun interface Sam {
fun foo()
}
fun aa() {
object : Sam {
override fun foo() {
object : Sam {
override fun foo() {
this
}
}
}
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(6, 5))
}
@Test
fun `call labeled 'this'`() {
val code = """
fun interface Sam {
fun foo()
}
class Target {
init {
object : Sam {
override fun foo() {
this@Target
}
}
}
}
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(7, 9))
}
@Test
fun `recursive call`() {
val code = """
fun interface Sam {
fun foo()
}
fun a() {
object : Sam {
override fun foo() {
foo()
}
}
}
"""
subject.compileAndLintWithContext(env, code).assert().isEmpty()
}
}
@Nested
inner class `Edge case` {
// https://github.com/detekt/detekt/pull/3599#issuecomment-806389701
@Test
fun `Anonymous objects are always newly created, but lambdas are singletons, so they have the same reference`() {
val code = """
fun interface Sam {
fun foo()
}
fun newObject() = object : Sam {
override fun foo() {
}
}
fun lambda() = Sam {}
val a = newObject() === newObject() // false
val b = lambda() === lambda() // true
"""
subject.compileAndLintWithContext(env, code)
.assert()
.hasSize(1)
.hasStartSourceLocations(SourceLocation(5, 19))
}
}
}
@Nested
@KotlinCoreEnvironmentTest(additionalJavaSourcePaths = ["java"])
inner class WithAdditionalJavaSources(val env: KotlinCoreEnvironment) {
@Test
fun `has other default methods`() {
val code = """
import com.example.fromjava.SamWithDefaultMethods
fun main() {
val x = object : SamWithDefaultMethods {
override fun foo() {
println()
}
}
}
"""
subject.lintWithContext(env, code).assert().hasSize(1)
}
@Test
fun `has only default methods`() {
val code = """
import com.example.fromjava.OnlyDefaultMethods
fun main() {
val x = object : OnlyDefaultMethods {
}
}
"""
subject.lintWithContext(env, code).assert().isEmpty()
}
@Test
fun `implements a default method`() {
val code = """
import com.example.fromjava.OnlyDefaultMethods
fun main() {
val x = object : OnlyDefaultMethods {
override fun foo() {
println()
}
}
}
"""
subject.lintWithContext(env, code).assert().isEmpty()
}
}
}