-
-
Notifications
You must be signed in to change notification settings - Fork 755
/
UnnecessaryInnerClassSpec.kt
464 lines (388 loc) · 13.3 KB
/
UnnecessaryInnerClassSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
package io.gitlab.arturbosch.detekt.rules.style
import io.gitlab.arturbosch.detekt.api.Config
import io.gitlab.arturbosch.detekt.rules.KotlinCoreEnvironmentTest
import io.gitlab.arturbosch.detekt.test.assertThat
import io.gitlab.arturbosch.detekt.test.lintWithContext
import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
@KotlinCoreEnvironmentTest
class UnnecessaryInnerClassSpec(val env: KotlinCoreEnvironment) {
val subject = UnnecessaryInnerClass(Config.empty)
@Test
fun `reports when an inner class does not access members of its outer class`() {
val code = """
val fileFoo = "FILE_FOO"
class A {
val foo = "BAR"
fun printFoo() {
println(foo)
}
inner class B {
val fizz = "BUZZ"
fun printFizz() {
println(fileFoo)
println(fizz)
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).hasSize(1)
}
@Nested
inner class `does not report an inner class accessing outer-class members` {
@Test
fun `as a default argument for a constructor`() {
val code = """
class A {
val foo = "BAR"
inner class B(val fizz: String = foo)
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `as a property initializer`() {
val code = """
class A {
val foo = "BAR"
inner class B {
val fizz = foo
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Nested
inner class `in a variable assignment` {
@Test
fun `where the outer-class variable is on the left`() {
val code = """
class A {
var foo = "BAR"
inner class B {
val fizz = "BUZZ"
init {
foo = fizz
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `where the outer-class variable is on the right`() {
val code = """
class A {
val foo = "BAR"
inner class B {
val fizz: String
init {
fizz = foo
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `where the outer-class variable is in a compound statement`() {
val code = """
class A {
val foo = "BAR"
inner class B {
val fizz: String
init {
fizz = "FOO" + foo
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
}
@Nested
inner class `in an if-statement` {
@Test
fun `where the outer-class variable is the only expression`() {
val code = """
class A(val foo: Boolean) {
inner class B {
fun printFoo() {
if (foo) {
println("FOO")
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `where the outer-class variable is on the left`() {
val code = """
class A {
val foo = "BAR"
inner class B {
fun printFoo() {
if (foo == "BAR") {
println("FOO")
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `where the outer-class variable is on the right`() {
val code = """
class A {
val foo = "BAR"
inner class B {
fun printFoo() {
if ("BAR" == foo) {
println("FOO")
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `where the outer-class variable is in a compound statement`() {
val code = """
class A {
val foo = "BAR"
inner class B {
val fizz = "BUZZ"
fun printFoo() {
if (fizz == "BUZZ" && foo) {
println("FOO")
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
}
@Test
fun `as a function initializer`() {
val code = """
class A {
fun printFoo() {
println("FOO")
}
inner class B {
fun printFizz() = printFoo()
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `as a function call`() {
val code = """
class A {
fun printFoo() {
println("FOO")
}
inner class B {
fun printFizz() {
printFoo()
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `as a function argument`() {
val code = """
class A {
val foo = "BAR"
inner class B {
fun printFizz() {
println(foo)
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `as a default value in a function signature`() {
val code = """
class A {
val foo = "BAR"
inner class B {
fun printFizz(fizzVal: String = foo) {
println(fizzVal)
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `as a safe qualified expression`() {
val code = """
class A {
var foo: String? = null
inner class B {
fun fooLength() {
foo?.length
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `to call a function of the member`() {
val code = """
class FooClass {
fun printFoo() {
println("FOO")
}
}
class A {
val foo = FooClass()
inner class B {
fun printFizz() {
foo.printFoo()
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `to call a function type variable of the member`() {
val code = """
class A {
val foo: () -> Unit = {}
inner class B {
fun bar() {
foo()
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
}
@Nested
inner class `does not report a double-nested inner class accessing from an outer-class member` {
@Test
fun `when the innermost class refers a inner class and the inner class refers the outermost class`() {
val code = """
class A {
val foo = "BAR"
inner class B {
val fizz = foo
inner class C {
fun printFoo() {
println(fizz)
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `when the innermost class refers the outermost class`() {
val code = """
class A {
val foo = "BAR"
inner class B {
inner class C {
fun printFoo() {
println(foo)
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `when the innermost class refers the outermost class via a labeled expression`() {
val code = """
class A {
inner class B {
inner class C {
fun outer(): A {
return this@A
}
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
}
@Test
fun `does not report anonymous inner classes`() {
val code = """
interface FooInterface {
fun doFoo()
}
class Foo {
fun runFoo(fi: FooInterface) {
fi.doFoo()
}
fun run() {
runFoo(object : FooInterface {
override fun doFoo() {
println("FOO")
}
})
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `does not report labeled expressions to outer class`() {
val code = """
class A {
inner class B {
fun outer(): A {
return this@A
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).isEmpty()
}
@Test
fun `reports irrelevant labeled expressions`() {
val code = """
class A {
inner class B {
fun inner() {
return Unit.apply { this@inner }
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).hasSize(1)
}
@Test
fun `reports when an inner class has this references`() {
val code = """
class A {
inner class B {
fun foo() {
this
}
}
}
""".trimIndent()
assertThat(subject.lintWithContext(env, code)).hasSize(1)
}
}