Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action runner fails if 'issue' was converted to a 'discussion' #24

Closed
abraunegg opened this issue May 27, 2021 · 3 comments
Closed

Action runner fails if 'issue' was converted to a 'discussion' #24

abraunegg opened this issue May 27, 2021 · 3 comments

Comments

@abraunegg
Copy link

abraunegg commented May 27, 2021

Hi,

I am trying to upgrade from using 'Lock Bot' to ' Lock Threads', however when this runs against open issues that should be locked, it runs into the following error:

Capture

Is there a configuration tweak in the lock.yml that I am missing or is this something that needs to be fixed as a bug?

@abraunegg
Copy link
Author

@dessant
The only solution I have found is to 'delete' the issues which were converted to a discussion.

Is it possible for you to workaround this issue so that issues that are converted to a discussion do not cause an error?

@dessant
Copy link
Owner

dessant commented May 28, 2021

The action is not yet aware of discussions, I'll release a fix in the near future.

@dessant
Copy link
Owner

dessant commented Aug 17, 2021

Issues that are converted to discussions are automatically locked by GitHub at the moment, so by default the action will ignore converted issues. It's possible to manually unlock the issue, though it has not much use since it's not possible to comment on unlocked issues that have been converted.

The error happens when a converted issue is unlocked and then picked up by the action. The API endpoint for issues and search results does not currently include any clue that an issue has been converted, while issues on GitHub show a link to the associated discussion. As a workaround the action now attempts to create a comment, and ignores the error if it indicates that the issue has been converted to a discussion.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants