Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering over GH Desktop's maximize button doesn't trigger Snap Layouts in Windows 11 #12542

Open
just1a-person opened this issue Jun 30, 2021 · 6 comments
Labels
windows Issues specific Desktop usage on Windows

Comments

@just1a-person
Copy link

Describe the bug

The new Snap Layouts feature in Windows 11 doesn't work with GitHub Desktop.

Version & OS

  • GitHub Desktop version: v2.9.0 (x64)
  • OS version: Windows 11 build 22000.51

Steps to reproduce the behavior

  1. Install Windows 11
  2. Open GitHub Desktop
  3. Hover over the maximize button.

Expected behavior

Triggers Snap Layouts

hovering over any other native window does trigger Snap Layouts

Actual behavior

Doesn't trigger Snap Layouts

hovering over GitHub Desktop doesn't trigger Snap Layouts

Additional context

microsoft/vscode#127449
electron/electron#29600

@steveward steveward added the windows Issues specific Desktop usage on Windows label Jul 12, 2021
@ScottArbeit
Copy link

Good news: electron/electron#29600 merged.

@ghost ghost deleted a comment from mjsweet01 Oct 27, 2021
@Gakk
Copy link

Gakk commented Apr 24, 2022

Even if electron/electron#29600 was merged into version 16.0.0 (and back ported to versjon 14 and 15) it still does not work on the current version 2.9.15 of GitHub Desktop using version 17.0.1 of Electron.

@MikeMcC399
Copy link

It would be great to see the Windows 11 Snap feature including "Snap layouts" enabled in GitHub Desktop. I'm not seeing it in the current version of GitHub Desktop 3.3.11 (x64).

Is there any chance to get this available?

Reference

Microsoft > Snap your windows

@MikeMcC399
Copy link

MikeMcC399 commented Mar 29, 2024

If you open the snap layout with the Windows Logo Key + Z then you can use Windows Snap with GitHub Desktop (in a kind of indirect way).

@ScottArbeit
Copy link

This was a problem at the Electron level, and was solved a while ago. It works for me on Windows 11 Insider Dev Channel Build 26090, and GitHub Desktop 3.3.12, and has worked for maybe 18 months now? Something like that....

@MikeMcC399
Copy link

@ScottArbeit

Windows 11 23H2 (OS Build 22631.3374)
GitHub Desktop 3.3.12 (x64)

If I hover with the mouse over the resize icon of the GitHub Desktop window, then I only see basic options, such as "Maximize". I don't see any snap options.

image

If I do the same with an application like Visual Studio Code I'm shown a whole set of snap options.

image

Are you saying that you are seeing snap options displayed when you hover over the icon in GitHub Desktop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues specific Desktop usage on Windows
Projects
None yet
Development

No branches or pull requests

5 participants