Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: older version and syntax usage of github.com/prometheus/common blocks patching cosign CVE #306

Open
lucasrod16 opened this issue Apr 17, 2024 · 1 comment · May be fixed by #307
Open

Comments

@lucasrod16
Copy link




Describe the bug
Not sure I would classify this as a bug or feature, but it's related to an older dependency version that is affecting us from patching a CVE in our codebase.

Usage of expfmt.FmtText from an older version of the github.com/prometheus/common dependency. The FmtText constant has been made private since v0.48.0.

https://github.com/prometheus/common/blob/c1b9b7252566d10e2ef16a827f454810c7f7fa56/expfmt/expfmt.go#L24-L53
https://github.com/prometheus/common/releases/tag/v0.48.0
prometheus/common#576

To Reproduce
Steps to reproduce the behavior:

  1. Clone the zarf repository
  2. Checkout the renovate/go-github.com/sigstore/cosign/v2-vulnerability branch from this PR that patches a cosign vulnerability
  3. From the root of the repo, run make to build the zarf binary

You can also view the error here in our CI without cloning the repo and manually reproducing:

https://github.com/defenseunicorns/zarf/actions/runs/8696598566/job/23850223859?pr=2437#step:4:91

Expected behavior
Our build succeeds

Screenshots
popeye

Versions (please complete the following information):

  • OS: M1 Mac
  • Popeye: v0.11.2
  • K8s: N/A
@lucasrod16
Copy link
Author

pusher = pusher.Format(expfmt.FmtText)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant