popeye 0.9.0 with K8S 1.21.0 bug on PodDisruptionBudget - Wrong default API

[pierrevillard]

Hi,
Popeye 0.9.0 has been released before Kubernetes K8S 1.21.0.
By default Popeye watch for PodDisruptionBudget resources on K8S API "policy/v1beta1/poddisruptionbudgets"
On K8S 1.21.0, PodDisruptionBudget has been migrated to API "policy/v1/poddisruptionbudgets"

In the next Popeye release, please add a check to force Popeye to watch for PodDisruptionBudget at API "policy/v1beta1/poddisruptionbudgets" for K8S < 1.21.X, and "policy/v1/poddisruptionbudgets" for K8S >= 1.21.X

[mingcheng]

and "policy/v1beta1/poddisruptionbudgets" for K8S >= 1.21.X

maybe

and "policy/v1/poddisruptionbudgets" for K8S >= 1.21.X

[johanfleury]

This makes popeye unusable on 1.21 (unless there’s a workaround that I couldn’t find).

IMO, this should be qualified as bug.

I’ll see if I can provide a PR for that.

[johanfleury]

I came with this diff, but I’m not sure it’ll actually work for < 1.21:

diff --git a/pkg/popeye.go b/pkg/popeye.go
index 78b44d8..bda13b8 100644
--- a/pkg/popeye.go
+++ b/pkg/popeye.go
@@ -128,7 +128,6 @@ func (p *Popeye) scannedGVRs(rev *version.Info) []string {
                "apps/v1/replicasets",
                "apps/v1/daemonsets",
                "apps/v1/statefulsets",
-               "policy/v1beta1/poddisruptionbudgets",
                "policy/v1beta1/podsecuritypolicies",
                "networking.k8s.io/v1/networkpolicies",
                "autoscaling/v1/horizontalpodautoscalers",
@@ -144,6 +143,12 @@ func (p *Popeye) scannedGVRs(rev *version.Info) []string {
                mm = append(mm, "networking.k8s.io/v1/ingresses")
        }

+       if rev.Minor == "20+" || rev.Minor == "19+" || rev.Minor == "18+" || rev.Minor == "17+" {
+               mm = append(mm, "policy/v1beta1/poddisruptionbudgets")
+       } else {
+               mm = append(mm, "policy/v1/poddisruptionbudgets")
+       }
+
        return mm
 }

@@ -213,6 +218,10 @@ func (p *Popeye) sanitizers(rev *version.Info) map[string]scrubFn {
                mm["networking.k8s.io/v1beta1/ingresses"] = scrub.NewIngress
        }

+       if rev.Minor == "20+" || rev.Minor == "19+" || rev.Minor == "18+" || rev.Minor == "17+" {
+               mm["policy/v1beta1/poddisruptionbudgets"] = scrub.NewPodDisruptionBudget
+       }
+
        return mm
 }

[derailed]

Fixed v0.9.4. Thank you all for weighting in!

[lee-harmonic]

This appears to still be happening with popeye v0.9.6 and kubernetes 1.21.3. Also, the category is repeated.

PODDISRUPTIONBUDGETS (1 SCANNED)                                               💥 0 😱 1 🔊 0 ✅ 0 0٪
┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅
  · test-ns/test-pdb...................................................................😱
    😱 [POP-403] Deprecated PodDisruptionBudget API group "policy/v1". Use "policy/v1beta1" instead.


PODDISRUPTIONBUDGETS (1 SCANNED)                                               💥 0 😱 1 🔊 0 ✅ 0 0٪
┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅┅
  · test-ns/test-pdb...................................................................😱
    😱 [POP-403] Deprecated PodDisruptionBudget API group "policy/v1". Use "policy/v1beta1" instead.

[pierrevillard]

@lee-harmonic,

Does your "kubectl" version is 1.21.x too ?

[derailed]

@lee-harmonic Doh - Great catch! Thank you Lee!! Will fix in the next drop.

[derailed]

Fixed v0.20.0