Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commons): handle node(s) contained by SVG document when deciphering url properties #2054

Merged
merged 8 commits into from Feb 27, 2020
Merged

fix(commons): handle node(s) contained by SVG document when deciphering url properties #2054

merged 8 commits into from Feb 27, 2020

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Feb 18, 2020 •
edited by WilcoFiers

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@jeeyyy jeeyyy requested a review from a team as a code owner February 18, 2020 18:42
WilcoFiers
WilcoFiers previously requested changes Feb 19, 2020
View reviewed changes
lib/commons/dom/url-props-from-attribute.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously requested changes Feb 25, 2020
View reviewed changes
lib/commons/dom/url-props-from-attribute.js Outdated Show resolved Hide resolved
@jeeyyy jeeyyy merged commit 41786b5 into develop Feb 27, 2020
@jeeyyy jeeyyy deleted the fix-url-props branch February 27, 2020 17:39
straker pushed a commit that referenced this pull request Mar 6, 2020
@jeeyyy @straker
fix(commons): handle node(s) contained by SVG document when de… (#2054)
bf4c9bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeeyyy @WilcoFiers