Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Update modules to go 1.16.3 code #9

Merged
merged 2 commits into from May 3, 2021
Merged

Update modules to go 1.16.3 code #9

merged 2 commits into from May 3, 2021

Conversation

jeffwidman
Copy link
Member

@jeffwidman jeffwidman commented Apr 28, 2021

This is the output of running script/extract locally on my Mac which
is running go 1.16.3.

I suspect this pulls in a few fixes/changes in how go module machinery
works.

I was uncertain whether to use tip of master on go, but thought better
to use a stable version as that'd likely be more stable/predictable for folks
comparing how the go get machinery works natively with how dependabot is working.

Especially since some of that machinery is in heavy development due to golang/go#36460.
Better to stick with more stable code for now.

I also bumped the go.mod/go.sum files in this repo to go 1.16 to match...

Fix #8.

This is the output of running `script/extract` locally on my Mac which
is running `go 1.16.3`.

I suspect this pulls in a few fixes/changes in how go module machinery
works.

I was uncertain whether to use tip of master on `go`, but thought better
to use a stable version as that'd likely be more predictable.
@@ -1,4 +1,2 @@
github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30 h1:yv5QpAklti/aXzXutayHrR0H5q/scACFjhapn5ghONo=
github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30/go.mod h1:6iRWK5o4q/zaYE+7CCrJw+orU8YTOQk+6ceIsR/i+4c=
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines were the result of running go mod tidy in this directory after updating the go.mod file to go 1.16.

@jeffwidman
Copy link
Member Author

gentle nudge @thepwagner @jurre

I'd like to push this across the line while it's fresh in my brain.

@thepwagner thepwagner self-assigned this May 3, 2021
@thepwagner
Copy link
Contributor

Repeated script/extract with similar enough results, thanks for this bump!

$ git log -1 && git diff HEAD..jeffwidman/update-modules-to-go-1.16.3-code
commit ec9f2b518fe6d0b0fc85a6e55e43ff7f97c95923 (HEAD -> go-modules-extracted-2021-05-03)
Author: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
Date:   Mon May 3 06:43:52 2021 -0400

    local
diff --git a/extract/go.mod b/extract/go.mod
index dca9cb0..2c5af73 100644
--- a/extract/go.mod
+++ b/extract/go.mod
@@ -1,5 +1,5 @@
 module github.com/dependabot/gomodules-extracted/extract

-go 1.15
+go 1.16

 require github.com/hmarr/pkgextract v0.1.0
diff --git a/extract/go.sum b/extract/go.sum
index 772ddbd..cdbecec 100644
--- a/extract/go.sum
+++ b/extract/go.sum
@@ -1,4 +1,2 @@
-github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30 h1:yv5QpAklti/aXzXutayHrR0H5q/scACFjhapn5ghONo=
-github.com/hmarr/pkgextract v0.0.0-20181020214423-fb37ca687b30/go.mod h1:6iRWK5o4q/zaYE+7CCrJw+orU8YTOQk+6ceIsR/i+4c=
 github.com/hmarr/pkgextract v0.1.0 h1:h6foxcQmFOSWvzAN5TwVoU33zjT8KZISSX/Godj7ZzM=
 github.com/hmarr/pkgextract v0.1.0/go.mod h1:6iRWK5o4q/zaYE+7CCrJw+orU8YTOQk+6ceIsR/i+4c=
diff --git a/go.mod b/go.mod
index e819ba2..6d92b24 100644
--- a/go.mod
+++ b/go.mod
@@ -1,3 +1,3 @@
 module github.com/dependabot/gomodules-extracted

-go 1.15
+go 1.16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-generate using go 1.16 code?
2 participants