Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default github-token #83

Merged
merged 2 commits into from Feb 28, 2022
Merged

Default github-token #83

merged 2 commits into from Feb 28, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Aug 23, 2021

Would it make sense for the github-token default value to be ${{ github.token }}, consistent with actions/checkout?

@jablko jablko requested a review from a team as a code owner August 23, 2021 16:49
@jablko
Copy link
Contributor Author

jablko commented Feb 23, 2022

@mwaddell @brrygrdn I've rebased this PR. Is it an overall unwelcome change, or are there issues with it that I could maybe address?

brrygrdn
brrygrdn previously approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@brrygrdn brrygrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing this, I think making this consistent with actions/checkout makes a load of sense, I can see how users would find it surprising it isn't.

@brrygrdn brrygrdn merged commit f4b2d0d into dependabot:main Feb 28, 2022
@brrygrdn brrygrdn mentioned this pull request Feb 28, 2022
Merged
@kachick kachick mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brrygrdn brrygrdn brrygrdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jablko @brrygrdn