Improve directory name extraction from branch name. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreid
force-pushed
the
dreid-improve-directory-extraction
branch
from
a4a8652
to
66389d7
Compare
|
👋 thanks for this! I'm on paternity leave right now so hesitant to merge this until I return, as I don't want to risk any problems that others would have to cleanup... but when I return in June I plan to take a look at this and hopefully ship it. |
Nishnha
reviewed
Apr 24, 2024
|
|
||
| if (data['updated-dependencies']) { | ||
| return await Promise.all(data['updated-dependencies'].map(async (dependency, index) => { | ||
| const dirname = `/${chunks.slice(2, -1 * (1 + (dependency['dependency-name'].match(/\//g) || []).length)).join(delim) || ''}` | ||
| const dirname = `/${chunks.slice(2, -1 * (delimIsDash ? 2 : 1 + (dependency['dependency-name'].match(/\//g) || []).length)).join('/') || ''}` |
There was a problem hiding this comment.
Hi I'm trying to wrap my head around this change. Would you mind explaining how it works and what featch-metadata was doing before?
Also, I'm surprised that we didn't have to update any existing tests! I guess we didn't have any test cases for separators?
|
There are some merge conflicts that you will need to resolve by rebasing/merging and re-running the build script before I can merge this |
Nishnha
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
Fixes #494
This improves directory extraction to handle two previously unhandled cases:
/-included in thedepname-versionportion is properly accounted for when the delimiter is-.I did not address the fact that the existing non-standard separator test uses a separator (
|) that does not appear to be valid according to the dependabot documention.