New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return compatibility score #146
Conversation
I'll add a separate |
Done. |
targetBranch: string, | ||
prevVersion: string, | ||
newVersion: string, | ||
compatScore: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to double check out API to see how we handle Dependency Score unknown
in the API as I can't remember off the top of my head.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just need to double check our API behaviour in one case, otherwise this looks great.
Thanks for adding a separate input flag for this lookup as well 🚀
}) | ||
|
||
const scoreChunk = svg.match(/<title>compatibility: (?<score>\d+)%<\/title>/m) | ||
return scoreChunk?.groups ? parseInt(scoreChunk.groups.score) : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #98
NOTE: This PR is a branch off of (and depends upon #144), so merging this one first would also merge that one too.