Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect MSBuild property DirectoryPackagesPropsPath that overrides directory.packages.props name and location #9696

Open
1 task done
m-naj opened this issue May 10, 2024 · 0 comments
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@m-naj
Copy link

m-naj commented May 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

MSBuild

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

.NET SDK allows Central Package Management file: directory.packages.props to be overriden thru MSBuild property: DirectoryPackagesPropsPath . The file name and path to it can be customized
Example:
<DirectoryPackagesPropsPath>$([MSBuild]::NormalizePath('$(MSBuildThisFileDirectory)', 'foobar.props'))</DirectoryPackagesPropsPath>

Request for Dependabot to respect and make updates to file defined in DirectoryPackagesPropsPath

dependabot.yml content

No response

Updated dependency

No response

What you expected to see, versus what you actually saw

Expected: Dependabot respects path defined in DirectoryPackagesPropsPath and updates the file in its PRs
Actual: Dependabot only updates directory.packages.props in root directory or in parent directories of project.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@m-naj m-naj added the T: bug 🐞 Something isn't working label May 10, 2024
@abdulapopoola abdulapopoola added the L: dotnet:nuget NuGet packages via nuget or dotnet label May 12, 2024
samtrion added a commit to dailydevops/dotnet-engineering that referenced this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
Status: Planned
Development

No branches or pull requests

2 participants