Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-directory support bug with go, terraform, docker #9664

Open
1 task done
carlincherry opened this issue May 3, 2024 · 4 comments
Open
1 task done

Multi-directory support bug with go, terraform, docker #9664

carlincherry opened this issue May 3, 2024 · 4 comments
Labels
L: git:submodules Git submodules L: go:modules Golang modules T: bug 🐞 Something isn't working

Comments

@carlincherry
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

go

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

No response

Updated dependency

No response

What you expected to see, versus what you actually saw

#2178 (comment)

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@lucacome
Copy link

lucacome commented May 3, 2024

Thanks @carlincherry!
You can see the config here https://github.com/nginxinc/nginx-gateway-fabric/blob/main/.github/dependabot.yml and the PR with only one update nginxinc/nginx-gateway-fabric#1921

@carlincherry
Copy link
Member Author

This also happens in Terraform and Docker

@ivanvc
Copy link

ivanvc commented May 3, 2024

This is my dependabot configuration: https://github.com/ivanvc/etcd/blob/77b2dfdaedc602904b208d91127b7a4d9ed66be7/.github/dependabot.yml#L9-L23.

A good example of it failing is that it created two PRs for the same dependency:

In other instances, it created a single PR updating the dependency in a single location, rather than everywhere it is referenced:

ivanvc/etcd#38

tests/go.mod
69:     github.com/gorilla/websocket v1.4.2 // indirect

server/go.mod
56:     github.com/gorilla/websocket v1.4.2 // indirect

go.mod
59:     github.com/gorilla/websocket v1.4.2 // indirect

@carlincherry carlincherry changed the title Multi-directory support bug with go Multi-directory support bug with go, terraform, docker May 3, 2024
@ivanvc
Copy link

ivanvc commented May 7, 2024

Now, it seems like dependabot stopped working with the configuration I provided. We're still getting dependabot PRs with the old configuration at etcd-io/etcd. But my fork (ivanvc/etcd), which has the new configuration, hasn't received any go-related version PR bumps.

The configuration seems to be valid as of ivanvc/etcd@ad4baf0: https://github.com/ivanvc/etcd/runs/24565853947. But there are no new PR in the last week: https://github.com/ivanvc/etcd/pulls?q=is%3Aopen+is%3Apr+author%3Aapp%2Fdependabot+label%3Ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules L: go:modules Golang modules T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants