Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate native javascript helpers to use ecmascript modules #9568

Open
jurre opened this issue Apr 23, 2024 · 0 comments
Open

Migrate native javascript helpers to use ecmascript modules #9568

jurre opened this issue Apr 23, 2024 · 0 comments
Labels
good first issue javascript Dependabot pull requests that update Javascript code L: git:submodules Git submodules L: javascript:npm npm packages via npm L: javascript:pnpm npm packages via pnpm L: javascript:yarn npm packages via yarn L: javascript T: tech-debt ⚙️

Comments

@jurre
Copy link
Member

jurre commented Apr 23, 2024

Code improvement description

Currently our native javascript helpers are using commonjs. However, we depend on some packages that have migrated to EcmaScript Modules and do not support being loaded via commonjs.

Namely #5683 has been blocked on this for a long time.

@deivid-rodriguez has made an initial pass at migrating our helpers to ESM, and we should get that change over the line so we can merge that update to detect-indent.
@jurre jurre added good first issue javascript Dependabot pull requests that update Javascript code L: javascript L: javascript:npm npm packages via npm L: javascript:pnpm npm packages via pnpm L: javascript:yarn npm packages via yarn T: tech-debt ⚙️ labels Apr 23, 2024
@github-actions github-actions bot added the L: git:submodules Git submodules label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue javascript Dependabot pull requests that update Javascript code L: git:submodules Git submodules L: javascript:npm npm packages via npm L: javascript:pnpm npm packages via pnpm L: javascript:yarn npm packages via yarn L: javascript T: tech-debt ⚙️
Projects
Dependabot
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jurre