fix fragment in suggested_changelog_url causing exceptions #9604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nishnha
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9565
The method
changelog_from_suggested_urlis trying to get a listing of the files so it can return them and get thehtml_url, sotmp_filesshould always be an array.The reason it wasn't is because
suggested_changelog_urlhad a fragment (e.g.#v2.8.6) which theSource.from_urldoesn't handle, so we end up grabbing the file itself rather than the directory listing.By stripping the fragment we get the listing which fixes the problem.
This is all a bit strange. It's weird we're using
Source.from_urlwhen we could useURIto parse. Also if we have the URL to the changelog it seems like we could transform the URL into the HTML URL without making a network call.But for now I'll put this fix in and slowly back away...