Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A commit created by Dependabot contains a file treating unchanged parts as changed in the diff #9537

Open
1 task done
Takym opened this issue Apr 19, 2024 · 0 comments
Open
1 task done
Labels
L: git:submodules Git submodules L: github:actions GitHub Actions T: bug 🐞 Something isn't working

Comments

@Takym
Copy link

Takym commented Apr 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

GitHub Actions

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/YigtyORG/TakymLib/tree/master/.github/workflows

dependabot.yml content

https://github.com/YigtyORG/TakymLib/blob/master/.github/dependabot.yml

Updated dependency

No response

What you expected to see, versus what you actually saw

  • Actual Behaviour: https://github.com/YigtyORG/TakymLib/pull/207/files
    • It seems like the whole file changed.
    • A part of the diff: (actual diff shows whole file changed)
      -    steps:
      -    - uses: actions/checkout@v3
      -      with:
      -        submodules: recursive
      +    steps:
      +    - uses: actions/checkout@v4
      +      with:
      +        submodules: recursive
    • Also, this behavior makes conflicts occur when merging in the local repository.
    • When I merged Dependabot PR on the web, in the local repository, the git command recognized the file concerned as changed even if the file has no change, and I cannot discard those "no change" changes.
  • Expected Behaviour
    • Diff should show only changed lines:
          steps:
      -    - uses: actions/checkout@v3
      +    - uses: actions/checkout@v4
            with:
              submodules: recursive
    • Also, conflicts should not occur on lines where nothing has changed.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

Smallest manifest that reproduces the issue

No response

@Takym Takym added the T: bug 🐞 Something isn't working label Apr 19, 2024
@github-actions github-actions bot added L: git:submodules Git submodules L: github:actions GitHub Actions labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules L: github:actions GitHub Actions T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant