Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong NuGet dependency updated, not matching the dependency mentioned in PR title and description #9536

Open
1 task done
skwasjer opened this issue Apr 19, 2024 · 0 comments
Labels
L: git:submodules Git submodules T: bug 🐞 Something isn't working

Comments

@skwasjer
Copy link

skwasjer commented Apr 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

NuGet

Package manager version

No response

Language version

C# 12

Manifest location and content before the Dependabot update

Directory.Build.props
test/Directory.Build.targets

dependabot.yml content

dependabot.yml

Updated dependency

  • xunit from 2.6.2 to 2.7.1
  • NetTestSdkVersion from 17.8.0 to 17.9.0

What you expected to see, versus what you actually saw

I received 2 PR's around the same time for 2 different dependencies.

Both PR's contain the wrong diff.

I expected the diff to update the dependency as is stated in the PR title/description, but it actually contains changes that seem to be targeting a different dependency (PackageVersion_Microsoft_Extensions via a property).

Expected

Directory.Build.props left unchanged.

test/Directory.Build.props:

-  <PackageReference Include="xunit" Version="2.6.2" />
+  <PackageReference Include="xunit" Version="2.7.1" />

Actual

Directory.Build.props:

   <PackageVersion_Microsoft_Extensions>8.0.0</PackageVersion_Microsoft_Extensions>
-  <PackageVersion_Microsoft_Extensions Condition="'$(TargetFramework)'=='net6.0'">6.0.0</PackageVersion_Microsoft_Extensions>
-  <PackageVersion_Microsoft_Extensions Condition="$(TargetFramework.StartsWith('netstandard2')) Or '$(TargetFramework)'=='net5.0'">5.0.0</PackageVersion_Microsoft_Extensions>
+  <PackageVersion_Microsoft_Extensions Condition="'$(TargetFramework)'=='net6.0'">8.0.0</PackageVersion_Microsoft_Extensions>
+  <PackageVersion_Microsoft_Extensions Condition="$(TargetFramework.StartsWith('netstandard2')) Or '$(TargetFramework)'=='net5.0'">8.0.0</PackageVersion_Microsoft_Extensions>

test/Directory.Build.props: has not changed

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

Smallest manifest that reproduces the issue

No response

@skwasjer skwasjer added the T: bug 🐞 Something isn't working label Apr 19, 2024
@github-actions github-actions bot added the L: git:submodules Git submodules label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant