Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET Tools updates in a repository that only contains a tools manifest #9408

Open
1 task done
martincostello opened this issue Apr 2, 2024 · 1 comment · May be fixed by #9411
Open
1 task done

Support .NET Tools updates in a repository that only contains a tools manifest #9408

martincostello opened this issue Apr 2, 2024 · 1 comment · May be fixed by #9411
Labels
L: git:submodules Git submodules T: feature-request Requests for new features

Comments

@martincostello
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

I have a GitHub workflow that uses some .NET global tools to do things where the versions were pinned using environment variables. I had the idea that if I used a .config/dotnet-tools.json file to specify the versions instead, I could leverage dependabot to keep the tools up-to-date without me needing to manually bump the versions (see martincostello/github-automation@64b1cd7).

However, it turns out that this won't work as-is because my repository doesn't contain any .NET code:

Errored with the message "Dependabot couldn't find a *.(sln|csproj|vbproj|fsproj|proj)"

image

It would be beneficial to update the relevant code to support this scenario by checking for the presence of a .config/dotnet-tools.json file in the root of the repository so that the job does not bail-out early with an error.
@martincostello martincostello added the T: feature-request Requests for new features label Apr 2, 2024
@github-actions github-actions bot added the L: git:submodules Git submodules label Apr 2, 2024
martincostello added a commit to martincostello/github-automation that referenced this issue Apr 2, 2024
@martincostello
Add sentinel project for dependabot
d1c355e 
Attempt to workaround dependabot/dependabot-core#9408.
@martincostello martincostello mentioned this issue Apr 2, 2024
Merged
martincostello added a commit to martincostello/github-automation that referenced this issue Apr 2, 2024
@martincostello
Add sentinel project for dependabot
5de6be7 
Attempt to workaround dependabot/dependabot-core#9408.
martincostello added a commit to martincostello/dependabot-core that referenced this issue Apr 2, 2024
@martincostello
Allow repo with only a dotnet-tools.json file
e98ce35 
Allow a repository to only contain a `dotnet-tools.json` file for .NET dependabot updates.
Resolves dependabot#9408.
@martincostello martincostello linked a pull request Apr 2, 2024 that will close this issue
Open
@xt0rted
Copy link

xt0rted commented Apr 9, 2024

I've run into this a number of times, and again just now. In my situation the repo is using full framework and a couple non-sdk style projects so I can't use dependabot on the projects, but I do want it on the local tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L: git:submodules Git submodules T: feature-request Requests for new features
Projects
Dependabot
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow repo with only a dotnet-tools.json file martincostello/dependabot-core
2 participants
@xt0rted @martincostello