Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if we can leverage composer's outdated command #5721

Closed
jeffwidman opened this issue Sep 14, 2022 · 4 comments
Closed

See if we can leverage composer's outdated command #5721

jeffwidman opened this issue Sep 14, 2022 · 4 comments
Labels
L: php:composer Issues and code for Composer T: tech-debt ⚙️

Comments

@jeffwidman
Copy link
Member

jeffwidman commented Sep 14, 2022

composer supports an outdated command which we may potentially be able to leverage to see which libraries are outdated.

The output has sections for both direct and transitive deps, and it supports a --major-only flag to show only packages with major version updates.

I am not familiar enough with the Dependabot composer implementation, but I know we use composer as a library for native helpers... if we do check outdated at all, it'd be convenient if we could flip to directly calling composer cli with some of these flags.

See also:

@jeffwidman
Copy link
Member Author

Per @driskell 's feedback here, directly calling the composer CLI has some hurdles.

But even sticking with the library, we may still be able to leverage the underlying PHP functions that are used in outdated... Or we may even already do this, I'm not really sure. 🤷‍♂️

@driskell
Copy link
Contributor

Outdated would work to check what needs running through the update. But I remember from testing the “is there an update available?” part of the dependabot update was not slow at all. If you had a drupal repository with lots of packages with no updates needed it would run through super quick. It only time out if there was updates as each package update would take some time to resolve the package set after updating.

@jeffwidman
Copy link
Member Author

Gotcha. So this wouldn't be a performance win, but may provide a small maintenance win... not sure. I'll leave this open in case someone want to play with it at some point... I know I'd like to do it at some point, but it's not urgent and probably won't actually happen until we have some other need to refactor the composer check.

@jeffwidman
Copy link
Member Author

I looked into this a little more, and it doesn't really make sense right now to do this... maybe down the road it might, but what we've got works well enough.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: php:composer Issues and code for Composer T: tech-debt ⚙️
Projects
None yet
Development

No branches or pull requests

2 participants