Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lowpri] Not fully compatible with some Facebook repos #1547

Closed
mrkev opened this issue Nov 29, 2019 · 1 comment
Closed

[lowpri] Not fully compatible with some Facebook repos #1547

mrkev opened this issue Nov 29, 2019 · 1 comment

Comments

@mrkev
Copy link

mrkev commented Nov 29, 2019

Hello, I work at Facebook and I help maintain Draft.js.

At Facebook, we have repos that live externally and are pulled in, (ie, React, Jest), and others that live in the Facebook codebase and are synced with Github via a our @facebook-github-bot (ie, Flow, Draft.js, React Native).

The workflow for the latter is we will clone the PR to our internal VCS, review and run checks against our codebase/infra internally, and then merge it, internally. @facebook-github-bot will then make sure the commit is reported on the github repo and will close the PR and associated issues.

I recently merged a PR from @dependabot and noticed it thought I was ignoring it because the PR was closed instead of merged (facebookarchive/draft-js#2259 (comment)). Now, this is not a huge issue since it will keep notifying me about future versions, just wont notify me about the release I just ignored. This seems like a low-pri issue because that's the version I just merged, though it does raise some questions:

  • Draft.js has multiple package.json in subdirectories— let's say we get a PR for one of them and merge it (but @dependabot thinks we ignored it). Does that mean we won't hear about this version on the other package.json files, or would this not happen because we'd receive the PR for all at the same time?
  • Do other organizations follow the same workflow as us here? Would it be something worth looking into?

Anyway, thanks for your work on @dependabot. It's a pretty cool project! (:

@stale
Copy link

stale bot commented Jan 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

@stale stale bot added the stale label Jan 28, 2020
@stale stale bot closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant