Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working with Vue3 #610

Closed
The-Outrider opened this issue Nov 18, 2020 · 8 comments · Fixed by #625
Closed

Not working with Vue3 #610

The-Outrider opened this issue Nov 18, 2020 · 8 comments · Fixed by #625
Labels
bug

Comments

@The-Outrider
Copy link

First and foremost, love this package, thank you for all your work on this.

Bug Description

A description of the bug

When running depcheck it throws an error: "Vue packages version mismatch"

  • vue@3.0.2 (/Users/xxx/node_modules/vue/index.js)
  • vue-template-compiler@2.6.12 (/Users/xxxx/node_modules/vue-template-compiler/package.json)

Vue3 doesn't use the template compiler anymore though. As mentioned here:

vuejs/core#670 (comment)

Versions

  • node -v: 12.13.0
  • npm -v: 6.13.1
  • depcheck --version: 1.3.1
@hvitis
Copy link

hvitis commented Feb 13, 2021

Bumping up!

rumpl added a commit that referenced this issue Feb 14, 2021
@rumpl
Use @vue/compiler-sfc
545f090 
Fixes #610
@rumpl rumpl mentioned this issue Feb 14, 2021
Merged
@rumpl
Copy link
Member

rumpl commented Feb 14, 2021

👋 I just opened a PR #625

Can someone test that branch and tell me if it works? I don't really know vue... I added a test but I have no idea if the component I created is a vue 3 one

rumpl added a commit that referenced this issue Feb 14, 2021
@rumpl
Use @vue/compiler-sfc
264ac54 
Fixes #610
@rumpl
Copy link
Member

rumpl commented Feb 16, 2021

@The-Outrider @hvitis ping nudge nudge :)

@The-Outrider
Copy link
Author

I'll review later this afternoon (Europe time) ✌️ @rumpl

@The-Outrider
Copy link
Author

I can confirm success! @rumpl Looks good!

@rumpl
Copy link
Member

rumpl commented Feb 16, 2021

Woop woop let's goooo! 🎉

@rumpl
Copy link
Member

rumpl commented Feb 16, 2021

I just released version 1.4.0 with this fix

@The-Outrider
Copy link
Author

Awesome :) Thank you very much

@mcasimir mcasimir mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use @vue/compiler-sfc depcheck/depcheck
3 participants
@rumpl @The-Outrider @hvitis