Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment Phone Number - Increase Cardinality from 5? #18112

Closed
1 of 2 tasks
Tracked by #16825
davidmpickett opened this issue May 13, 2024 · 7 comments
Closed
1 of 2 tasks
Tracked by #16825

Appointment Phone Number - Increase Cardinality from 5? #18112

davidmpickett opened this issue May 13, 2024 · 7 comments
Assignees
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Drupal Site Building For tasks that require Drupal Admin access, but don't require updating code or making a PR Facilities Facilities products (VAMC, Vet Center, etc) Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products VAMC CMS managed product owned by Facilities team

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented May 13, 2024

User Story or Problem Statement

After running the Service Location migration, @omahane discovered that there were 4 facility health services that had more appointment phone numbers than is allowed in the new content model.

When we drafted the content spec, we limited the number of appointment phone numbers to 5. This was in line with the existing limit of 5 contact phone #s per Service Location. However, we discovered that there had never been a limit set on Appointment Phone numbers previously (likely due to historical concerns about data migration). Out of 15,000 published VAMC facility health services, only 4 of them use more than 5 appointment phone numbers.

A cursory review of these four services does not seem to indicate that they are misusing the appointment phone # field type. They are simply services with a lot of different phone numbers.

Description or Additional Context

Appt phone #s FE link Drupal link
6 Women centered care - Captain James A. Lovell Federal Health Care Center Drupal
6 Primary care - Richmond VA Medical Center Drupal
7 Radiology - Syracuse VA Medical Center Drupal
9 Primary care - Wilmington VA Medical Center Drupal

What will happen if we do nothing

Proposed short term path

  • Increase the cardinality of this field from 5 to 9, this accounts for the current largest instance of appointment phone numbers while still preventing truly excessive phone number entry
  • Manually add the 8 phone numbers that were not migrated to the new appointment phone number field on the corresponding services

Another option that's probably not a good idea

  • Create a second service location on these services and move some phone numbers to that based on our interpretation of the content

Possible longer term follow up

  • Work with the editors of these services to understand if this information could/should be split into multiple service locations under the Service, rather than all under one service
  • Revisit the cardinality of this field

Acceptance Criteria

  • Number of Service Location appointment phone numbers possible is 9 rather than 5
  • Data that was not migrated (originally) is migrated (manually or auto) to Drupal
@davidmpickett davidmpickett added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Drupal Site Building For tasks that require Drupal Admin access, but don't require updating code or making a PR VAMC CMS managed product owned by Facilities team Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products CY24-Q2 Calendar year Q2 2024 priority labels May 13, 2024
@mmiddaugh
Copy link

Agreed - interpreting content and intended use is probably not the best play here.
I appreciate the manual effort on behalf of the editors given the valid and interesting use cases discovered.

@omahane
Copy link
Contributor

omahane commented May 15, 2024

@davidmpickett @mmiddaugh
service-location-additional-numbers-after-cardinatlity-change.xlsx
I have the additional numbers here. I would gladly change them but then I also have to set a lot of data I'm not sure about, including office visits, virtual support, and online scheduling. I could do that, but I'd need to have the editor go in and verify.

How would you like to proceed?

@jilladams
Copy link
Contributor

@mmiddaugh @omahane @davidmpickett to discuss and modify last AC as needed if we opt for editor reachout instead.

@jilladams
Copy link
Contributor

Confirmed with VHA DM in sync today:
We will coordinate with Helpdesk to reach out to the editors regarding populating the new required information. If we have any trouble VHA can help contact them.

@davidmpickett
Copy link
Contributor Author

Cardinality charge verified on prod
Screenshot 2024-05-15 at 4 15 49 PM

@omahane
Copy link
Contributor

omahane commented May 16, 2024

@jilladams We can close, as we've confirmed on prod and have editors making additional necessary additions to phone numbers.

@davidmpickett
Copy link
Contributor Author

Moved editor comms to separate ticket so this can close #18145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Drupal Site Building For tasks that require Drupal Admin access, but don't require updating code or making a PR Facilities Facilities products (VAMC, Vet Center, etc) Facility services (multi-product) A label for issues that affect how services are handled across multiple facility products VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants