Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography Audit: Remove Homepage Email Sign up custom styling #18111

Open
1 task
FranECross opened this issue May 13, 2024 · 2 comments
Open
1 task

Typography Audit: Remove Homepage Email Sign up custom styling #18111

FranECross opened this issue May 13, 2024 · 2 comments
Labels
Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

Description

The issues found have been corrected by changes the DS team implemented, however Randi M noticed custom styling on this section that needs to be removed (approved by Amanda K).

Reference Ticket #18078

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Custom code has been removed, and typography/home page displays as expected.
@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area labels May 13, 2024
@FranECross FranECross mentioned this issue May 13, 2024
Open
4 tasks
@randimays randimays changed the title Typography Audit: Remove Homepage Email Sign up section Typography Audit: Remove Homepage Email Sign up custom styling May 14, 2024
@laflannery
Copy link
Contributor

This seems like a duplicate - couldn't we just use the original ticket for the purpose of removing the custom styles?

@FranECross
Copy link
Author

I'm fine either way.

@FranECross FranECross removed the Needs refining Issue status label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laflannery @FranECross