LH V1: Migrate FacilitiesDrupalCMS API key calls to LIghthouse (Drupal migrations) to V1 endpoint

[jilladams]

User Story or Problem Statement

As a Lighthouse Facilities API user, I want all my API calls to route through V1 so that nothing breaks when V0 is deprecated on / around June 1.

Description or Additional Context

https://dsva.slack.com/archives/C02BTJTDFTN/p1715629775668819

For the Facilities API V1 migration we are tracking the VADOTGOV_FacilityLocator key used by the front end being migrated but have not discussed the FacilitiesDrupalCMS key. That looks like it is just the pushes from your end to our cms-overlay endpoint. We need to make sure that gets ported over too.

It should be as simple as changing /v0 to /v1 in the endpoint path as we tried to ensure that endpoint is version agnostic and we handle remapping the fields internally. We should of course verify with some pushes to Sandbox when you have the change staged on your side.

Documentation about the FacilitiesDrupalCMS API consumer: https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/facilities/facility-pages/technical-documentation.md#api-userkey

Scope

• Any Drupal migrations from Lighthouse that currently call the V0 endpoint, including both GET and POST

Steps for Implementation

Acceptance Criteria

• All LH API calls made by the FacilitiesDrupalCMS consumer are updated to use the /v1 endpoint
• MIgrations are verified for data fidelity on both sides, GET vs. POST

[jilladams]

GET is not hard to test
POST is harder, bc LH has to be available to verify it worked.

[omahane]

I tested the migrations of all facilities locally. They imported as expected.

I am awaiting the word from Lighthouse to test the data pushes (via Slack).

[omahane]

@jilladams @Agile6MSkinner @davidmpickett Currently, we are blocked on this per Adam on Slack.

[jilladams]

Noting: LH identified the blocker, will work this week to fix it, and we should be theoretically unblocked next week.

[jilladams]

Christian flagged that this ticket may be at risk for end of sprint, as we are testing the connection with Lighthouse right now and it is not clean / successful so far for the results we expect. Thread: https://dsva.slack.com/archives/C02BTJTDFTN/p1716489543944699

[omahane]

I have achieved success with importing an NCA facility.

That being said, we have different migration configuration for each facility type. Plus, it turns out that the data structure of V0 and V1 have changed, which I was not aware of when sizing this ticket.

Given the change to the data structure, I will not feel confident in these migrations without finding facilities with the most complete data in each facility type. That could take a while.

Sampling of each facility type

lighthouse-v1-sample.json

Likelihood of making the sprint deadline

It's possible that this will be ready to review on Tuesday. I don't know if it will be able to reviewed by then. I would say this went from 🟡 to 🔴 to be completed for the sprint.

[omahane]

While working on this ticket, I found that we have some tests of migrations:
tests/phpunit/Migration, which include text data under the tests/phpunit/Migration/fixtures/ folder.

I mentioned it in retro, and was asked about where we might document this.

Facility migrations are documented here: https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/READMES/migrations-facility.md