Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breakpoints] No Left/Right padding on smaller breakpoints on Event Detail pages #18102

Open
2 tasks
laflannery opened this issue May 10, 2024 · 4 comments
Open
2 tasks
Labels
Events product maintained by Public Websites team Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

Description

On smaller breakpoints (768 and below), some event detail pages don't have any left/right padding on the side of the screen, not all though, just some. For example:

Acceptance Criteria

  • All event detail pages should have proper padding at all breakpoints
  • Requires design review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew Events product maintained by Public Websites team labels May 10, 2024
@FranECross FranECross changed the title No Left/Right padding on smaller breakpoints on Event Detail pages [Breakpoints] No Left/Right padding on smaller breakpoints on Event Detail pages May 13, 2024
@randimays
Copy link
Contributor

This is a dupe of #16416 I think. We can combine description details there if you like

@laflannery
Copy link
Contributor Author

@randimays This is about detail pages, I think the one you made is about the landing page specifically? I don't disagree that they might be able to be combined because maybe they are solved the same way but I just want to be sure I'm reading that other ticket correctly before I combine them

@randimays
Copy link
Contributor

@laflannery Yes, mine was specific to landing pages. I think we can combine all the weirdness into one ticket (landing pages and detail pages) 👍🏻

@FranECross
Copy link

@FranECross combine tickets (see 16416) and then close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Events product maintained by Public Websites team Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants