-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typography Audit Issue: Global search results left/right padding #18099
Comments
@FranECross I've tagged this into Sprint 4, but please feel free to override if this doesn't feel like a priority for next sprint. @thejordanwood also happy to hear your opinion on priority here. |
I think this might be another instance of Local and RI showing different things - which again is slightly concerning because we were told either way of testing would be fine |
@jilladams @laflannery Circling back around on this one... I completely forgot @jilladams you'd tagged for Sprint 4, but to Randi's point, I think this might be a no op, or something the DST will fix/has a fix for? Should we wait and retest? cc @randimays |
DST has merged their fixes; need to validate on Prod @FranECross . If it's still an issue, then the PW team will need to take action. |
@FranECross I validated in production; everything looks fine to me (padding, text size, etc.). I'll lean on @laflannery to confirm. |
I'm also not seeing the issues in prod that we reported in the previous screenshots, we should be good to close this! |
Closing as a no-op per the above comments. |
Description
From Phase 1 of the Typography audit, an issue was found with the padding on the Global search results that should be reviewed:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: