Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography Audit Issue: Global search results left/right padding #18099

Closed
2 tasks
laflannery opened this issue May 10, 2024 · 8 comments
Closed
2 tasks

Typography Audit Issue: Global search results left/right padding #18099

laflannery opened this issue May 10, 2024 · 8 comments
Labels
Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

Description

From Phase 1 of the Typography audit, an issue was found with the padding on the Global search results that should be reviewed:

  1. The left/right padding has slightly increased on the global search results. While this is on all breakpoints, the concern is on the 320 breakpoint where the H1 now goes to 2 lines. The concern from UX is that because it dropd to 2 lines, it's just adding to the scroll length before users can see search results.
    Screenshot 2024-05-10 at 10 12 49 AM
    Screenshot 2024-05-10 at 10 13 52 AM

Acceptance Criteria

  • Heading for Search results does not drop to 2 lines on any breakpoint
  • Requires design review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Public Websites Scrum team in the Sitewide crew labels May 10, 2024
@jilladams
Copy link
Contributor

@FranECross I've tagged this into Sprint 4, but please feel free to override if this doesn't feel like a priority for next sprint. @thejordanwood also happy to hear your opinion on priority here.

@randimays
Copy link
Contributor

I tested this locally. Dropping my findings here. It feels to me like the typography scaling issues are something in DST's court but I could be wrong there.

Header line width issue

This seems either fixed or just not-reproducible on my end.

Screenshot 2024-05-13 at 2 33 54 PM

Typography scaling issues

It seems as though the default font size is 10px 🤔 Looking specifically at misalignment in the header and the tiny description text under each search result.

Screenshot 2024-05-13 at 2 33 05 PM Screenshot 2024-05-13 at 2 34 29 PM

@laflannery
Copy link
Contributor Author

I think this might be another instance of Local and RI showing different things - which again is slightly concerning because we were told either way of testing would be fine

@FranECross
Copy link

@jilladams @laflannery Circling back around on this one... I completely forgot @jilladams you'd tagged for Sprint 4, but to Randi's point, I think this might be a no op, or something the DST will fix/has a fix for? Should we wait and retest? cc @randimays

@FranECross
Copy link

DST has merged their fixes; need to validate on Prod @FranECross . If it's still an issue, then the PW team will need to take action.

@randimays
Copy link
Contributor

@FranECross I validated in production; everything looks fine to me (padding, text size, etc.). I'll lean on @laflannery to confirm.

@laflannery
Copy link
Contributor Author

I'm also not seeing the issues in prod that we reported in the previous screenshots, we should be good to close this!

@randimays
Copy link
Contributor

Closing as a no-op per the above comments.

@randimays randimays closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants