Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VBA Component - Update Card on Service Locations #18097

Closed
3 tasks
laflannery opened this issue May 9, 2024 · 2 comments
Closed
3 tasks

VBA Component - Update Card on Service Locations #18097

laflannery opened this issue May 9, 2024 · 2 comments
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

Description

On VBA, we need to update the Service location section to use the Card component.
Cleveland VA Regional Benefit Office (This is a tugboat)

So on a VBA page, there are service accordions - like Home loans. All the info about the location is contained within a bordered area. That border/area should have been using the Card component so that it has standard styles. Instead it's just using VADS classes to create that style.

Acceptance Criteria

  • The Service location info is contained within the Card component
  • Requires design review
  • Requires accessibility review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team labels May 9, 2024
@laflannery laflannery mentioned this issue May 9, 2024
Closed
11 tasks
@jilladams jilladams mentioned this issue May 15, 2024
Open
22 tasks
@laflannery
Copy link
Contributor Author

Based on the code, I think this is going to get handled in the VAMC Facilities ticket I will review/confirm once that is updated

@laflannery
Copy link
Contributor Author

I have confirmed that VBA services now use the card component (I built my tugboat using main to get this screenshot):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laflannery