Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography Audit Issue: Hours on Facility Locator Detail pages #18084

Open
2 tasks
laflannery opened this issue May 8, 2024 · 3 comments
Open
2 tasks

Typography Audit Issue: Hours on Facility Locator Detail pages #18084

laflannery opened this issue May 8, 2024 · 3 comments
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Needs refining Issue status UX debt Known issues with the user experience VA.gov frontend CMS team practice area

Comments

@laflannery
Copy link
Contributor

Description

From Phase 1 of the Typography audit, one issue with the Hours display on the Facility Locator detail pages:

  1. The padding on the standard columns class has increased. This means that the Hours display doesn't have as much space anymore and is wrapping:
    Screenshot 2024-05-08 at 4 23 20 PM
    • Even though this isn't necessarily using anything custom should we consider possible updates that make this look a bit nicer, the way it was previously?
      • Are there other classes that we could/should use that would have small padding?
      • We could also consider changing the 50/50 split of the columns to allow for more space in the second - since the first doesn't need as much

Acceptance Criteria

  • Hours display does not wrap
  • Requires design review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels May 8, 2024
@jilladams
Copy link
Contributor

This feels very deeply not urgent to me, given everything we have that is urgent, and that it's the FL detail page. I would like to vote this can hang in the icebox for a bit, but will let @Agile6MSkinner and @mmiddaugh confirm.

@jilladams
Copy link
Contributor

For Michael's context: modernized facilities like VAMCs and Vet Centers do not use this template. Only non-modernized facilities do. That includes Regional Benefit offices, until we get our modernized VBA work shipped (SOON, we are hoping), and cemeteries.

@jilladams jilladams added Facility Locator product owned by Facilities team Facility Locator detail page A page used in facility locator for non-modernized facility types Technical debt UX debt Known issues with the user experience and removed Facility Locator product owned by Facilities team Technical debt labels May 8, 2024
@jilladams
Copy link
Contributor

Laura also noted that this weird line breaking is already happening in prod at smaller breakpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Needs refining Issue status UX debt Known issues with the user experience VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants