Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ddtrace #1662

Open
2 of 7 tasks
mchlwellman opened this issue Feb 23, 2024 · 7 comments
Open
2 of 7 tasks

Upgrade ddtrace #1662

mchlwellman opened this issue Feb 23, 2024 · 7 comments

Comments

@mchlwellman
Copy link

mchlwellman commented Feb 23, 2024

User Story - Business Need

The Datadog dependencies were intentionally left untouched during the last dependencies update (#1647). This ticket addresses the need to upgrade dd-trace and it's submodules.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify developer
I want to upgrade Datadog dependencies
So that we minimize vulnerabilities and future upgrade pains

Additional Info and Resources

dd-trace Release Notes
Working branch is ddtrace-update
Current PR for this that failed on deploy, but passed unit tests

Breaking changes from v1 to v2.
On the branch, I followed our README documentation for updating dependencies with poetry. Passed local unit tests.

Engineering Checklist

  • Upgrade the dd-trace package via poetry
  • Update requirements.txt as described in README.md
  • Deploy to Dev, observe that the QA Suite passes and there are no errors related to this library in the logs
  • Review traces and ensure there are no issues

Acceptance Criteria

  • Regression tests pass
  • APM Traces are present without issues
@mchlwellman mchlwellman added dependencies Pull requests that update a dependency file Notify devops Review Needed labels Feb 23, 2024
@ldraney
Copy link

ldraney commented Feb 27, 2024

The Datadog agent image in ECR should be updated as a part of this, as it hasn't been updated since 2022!
image

use notification-api/.github/workflows/update-datadog-image.yaml to do so, keeping an eye out for unexpected changes.

This may have a positive impact on profiling and log digestion.

@mjones-oddball
Copy link

@mchlwellman Can you summarize what went wrong/happened when you tried to update this before? That will help whoever takes the ticket to understand the compexity/impacts.

@mjones-oddball
Copy link

Michael said the impact was for dnspython not this ticket.

@ldraney
Copy link

ldraney commented Mar 18, 2024

Kyle asked me to make a new ticket, and as I was getting informed I ended up just updating it and it passed.
I added the documentation etc to my PR

@ldraney
Copy link

ldraney commented Mar 18, 2024

Assuming it passes regression, I'll keep an eye on Datadog for a bit before asking for reviews on this.

@ldraney
Copy link

ldraney commented Mar 18, 2024

It did not pass deployment. First step will be to figure out why.
image.png

@ldraney ldraney changed the title Upgrade datadog dependencies Upgrade ddtrace Mar 18, 2024
@ldraney
Copy link

ldraney commented Mar 18, 2024

Note from Kyle: updating from v1 to later version of v1 also had deployment problems, so this may be more complex for pointing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants