-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ddtrace #1662
Comments
@mchlwellman Can you summarize what went wrong/happened when you tried to update this before? That will help whoever takes the ticket to understand the compexity/impacts. |
Michael said the impact was for dnspython not this ticket. |
Kyle asked me to make a new ticket, and as I was getting informed I ended up just updating it and it passed. |
Assuming it passes regression, I'll keep an eye on Datadog for a bit before asking for reviews on this. |
Note from Kyle: updating from v1 to later version of v1 also had deployment problems, so this may be more complex for pointing |
User Story - Business Need
The Datadog dependencies were intentionally left untouched during the last dependencies update (#1647). This ticket addresses the need to upgrade dd-trace and it's submodules.
User Story(ies)
As a VA Notify developer
I want to upgrade Datadog dependencies
So that we minimize vulnerabilities and future upgrade pains
Additional Info and Resources
dd-trace Release Notes
Working branch is ddtrace-update
Current PR for this that failed on deploy, but passed unit tests
Breaking changes from v1 to v2.
On the branch, I followed our README documentation for updating dependencies with poetry. Passed local unit tests.
Engineering Checklist
Acceptance Criteria
The text was updated successfully, but these errors were encountered: