-
Notifications
You must be signed in to change notification settings - Fork 15
/
.reek.yml
294 lines (291 loc) · 10.3 KB
/
.reek.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
### Generic smell configuration
### Please keep these alphabetical
detectors:
# You can disable smells completely
Attribute:
exclude:
- BulkTaskAssignment
- Hearing#override_full_hearing_day_validation
- PowerOfAttorney
- QueueConfig
- RatingDecision
BooleanParameter:
exclude:
- AsyncableJobsReporter#initialize
- HearingRepository#slot_new_hearing
- HearingRenderer
- LegacyDocket#distribute_appeals
- Veteran
- ControllerSchema#respond_to_missing?
- SanitizedJsonDifference
- JudgeTeam#create_for_judge
ControlParameter:
exclude:
- ExplainTimelineConcern::TimelineSpanData
- ExternalApi::VBMSService#self.send_and_log_request
- Fakes::BGSService
- Hearings::GeomatchAndCacheAppealJob#perform
- HearingRepository#slot_new_hearing
- HearingRenderer
- Hearings::SendEmail#initialize
- LegacyDocket#distribute_appeals
- SanitizedJsonDifference
- SanitizedJsonConfiguration
- Seeds::Tasks#create_legacy_case_with_open_schedule_hearing_task
- SlackService#pick_color
- Task#actions_allowable?
- TaskSorter#sort_requires_case_norm?
- VBMSCaseflowLogger#log
- Veteran
- VirtualHearing#email_recipient_name
- JudgeDecisionReviewTask#additional_available_actions
- LegacyDocket#should_distribute?
UncommunicativeVariableName:
exclude:
- Address
- Seeds::Intake#create_inbox_messages
- Seeds::MTV#setup_motion_to_vacate
- Seeds::Users
- Fakes::PersistentStore#convert_dates_from
UncommunicativeMethodName:
exclude:
- LegacyAppeal#appellant_address_line_1
- LegacyAppeal#appellant_address_line_2
UncommunicativeParameterName:
exclude:
- Address
- Api::V3::DecisionReviews::ContestableIssueFinder#initialize
DataClump:
exclude:
- ForeignKeyPolymorphicAssociationJob
- HearingSerializerBase
- LegacyDocket
- SanitizedJsonConfiguration
- SanitizedJsonImporter
- SanitizedJsonExporter
- Seeds::Tasks
- TaskTreeRenderModule
DuplicateMethodCall:
enabled: false
FeatureEnvy:
exclude:
- AMOMetricsReportJob#build_report
- Api::ApplicationController#on_external_error
- Api::ApplicationController#upstream_known_error
- AppealAvailableHearingLocations#suggested_hearing_location
- AppealTaskHistory#build_events
- AssignHearingDispositionTask#reschedule_or_schedule_later
- AsyncableJobsReporter
- CachedAppealService#cache_ama_appeals
- CachedAppealService#cache_legacy_appeal_postgres_data
- CachedAppealService#cache_legacy_appeal_vacols_data
- CachedAppealService#poa_representative_name_for
- CachedAppealService#case_fields_for_vacols_ids
- ConvertToVirtualHearing#convert_hearing_to_virtual
- ClaimReviewAsyncStatsReporter#as_csv
- DataIntegrityChecksJob
- DecisionIssueSyncJob
- ErdRecordAssociations
- ErdGraphStyling
- VirtualHearings::CreateConferenceJob#log_virtual_hearing_state
- VirtualHearings::DeleteConferencesJob#delete_conference
- VirtualHearings::DeleteConferencesJob#log_virtual_hearing_state
- VirtualHearings::DeleteConferencesJob#perform
- VirtualHearings::DeleteConferencesJob#process_virtual_hearing
- VirtualHearings::DeleteConferencesJob#send_cancellation_emails
- Hearings::SendEmail#external_message_id
- Fakes::EndProductStore
- Fakes::BGSService#get_participant_id_for_user
- Fakes::BGSServiceRecordMaker
- Fakes::BGSService#fetch_poas_by_participant_ids
- Fakes::PersistentStore#convert_dates_from
- FetchDocumentsForReaderJob#fetch_for_appeal
- FetchHearingLocationsForVeteransJob#sleep_before_retry_on_limit_error
- HearingSerializerBase
- HearingSchedule::GenerateHearingDaysSchedule#generate_co_hearing_days_schedule
- HearingSchedule::GenerateHearingDaysSchedule#get_fallback_date_for_co
- HearingSchedule::ValidateRoSpreadsheet#filter_invalid_range
- HearingRenderer
- LegacyDocket#count
- RedistributedCase#legacy_appeal_relevant_tasks
- LegacyAppeal#cancel_open_caseflow_tasks!
- MonthlyMetricsReportJob#build_report
- NightlySyncsJob#sync_vacols_cases
- Person#fetch_bgs_record_by_participant_id
- Person#fetch_bgs_record_by_ssn
- RequestIssue#find_or_create_decision_issue_from_rating_issue
- RequestIssue#special_issues
- RequestIssueReporter#as_csv
- RunAsyncable#perform_later_or_now
- SanitizedJsonConfiguration
- ScheduleHearingTask#create_hearing
- Seeds::Hearings
- Seeds::Tasks#create_colocated_legacy_tasks
- Seeds::Users#create_aod_user_and_tasks
- SlackService#http_service
- SyncReviewsJob
- TasksForAppeal#tasks_visible_to_vso_employee
- TaskTimerJob
- UpdateCachedAppealsAttributesJob
- UserReporter#report_user_related_records
- User#appeal_has_task_assigned_to_user?
- VeteranAttributeCacher
- HearingDayRequestTypeQuery#call
- WarmBgsCachesJob
- ExternalApi::PexipService#send_pexip_request
- ControllerSchema#remove_unknown_keys
- BusinessLineReporter#as_csv
InstanceVariableAssumption:
exclude:
- Appeal
- Task
- CaseflowJob
- Api::V3::DecisionReviews::HigherLevelReviewIntakeProcessor
- ETL::Syncer
- User
IrresponsibleModule:
enabled: false
LongParameterList:
exclude:
- Address#initialize
- AssignHearingDispositionTask#reschedule
- ExternalApi::VBMSService#self.create_contentions!
- JobSentryScopeMiddleware#call
- LegacyDocket#new_distributed_case
- Api::V3::DecisionReviews::ContestableIssueFinder#initialize
- QueueRepository#assign_case_to_attorney!
- SanitizedJsonDifference
- Seeds::MTV#judge_addresses_mtv
- Seeds::MTV#send_mtv_to_judge
- Seeds::Tasks#create_task_at_colocated
- VirtualHearings::CreateConferenceJob#perform
- Docket#distribute_appeals
- LegacyDocket#distribute_priority_appeals
- LegacyDocket#distribute_nonpriority_appeals
- ExternalApi::MPIService#search_people_info
ManualDispatch:
exclude:
- Api::V3::DecisionReviews::IntakeError#potential_error_code
- Api::V3::DecisionReviews::HigherLevelReviewIntakeParams#attributes?
- Api::V3::DecisionReviews::HigherLevelReviewIntakeParams#params?
- Api::V3::DecisionReviews::IntakeError#error_code
- Api::V3::DecisionReviews::HigherLevelReviewIntakeParams#claimant_object
- Api::V3::DecisionReviews::HigherLevelReviewIntakeParams#claimant_object_present?
- Api::V3::DecisionReviews::HigherLevelReviewIntakeParams#describe_shape_error
- ETL::Hearing#merge_original_attributes_to_target
- RouteDocsController::DocumentedRoute#schema
MissingSafeMethod:
enabled: false
NestedIterators:
max_allowed_nesting: 2
exclude:
- AsyncableJobsReporter
NilCheck:
enabled: false
RepeatedConditional:
exclude:
- BgsPowerOfAttorney
- BulkTaskReassignment
- ExplainController
- HearingLocation
- HearingRenderer
- LegacyAppeal
- Person
- QueueConfig
- RequestIssue
- Seeds::Hearings
- Task
- UpdateCachedAppealsAttributesJob
- Veteran
- LegacyDocket
TooManyConstants:
exclude:
- Fakes::BGSServicePOA
TooManyInstanceVariables:
exclude:
- AmaAppealDispatch
- DuplicateUserTask
- LegacyAppealDispatch
- Address
- SanitizedJsonImporter
- ExternalApi::PexipService
- InvalidAssigneeStatusOnTaskCreate
- Api::V3::DecisionReviews::ContestableIssueFinder
- Api::V3::DecisionReviews::ContestableIssueParams
- Api::V3::DecisionReviews::IntakeError
- ControllerSchema::Field
- HearingEmailStatusMailer
TooManyMethods:
enabled: false
TooManyStatements:
enabled: false
UtilityFunction:
public_methods_only: true
exclude:
- AddressMapper#get_address_from_veteran_record
- ClaimReviewAsyncStatsReporter#seconds_to_hms
- ETLClasses#syncer_klasses
- ETL::Builder#last_built
- ETL::HearingSyncer#filter?
- ETL::LegacyHearingSyncer#filter?
- ETL::Syncer#filter?
- ETL::TaskSyncer#filter?
- Fakes::BGSService
- Fakes::RatingStore
- Fakes::PexipService
- HearingAdminActionVerifyAddressTask#available_hearing_admin_actions
- HearingDispositionChangeJob
- Helpers::AppealHearingHelper#available_hearing_locations
- Helpers::AppealHearingHelper#hearings
- HearingRenderer
- JudgeLegacyDecisionReviewTask#review_action
- LatestRatingDisabilityEvaluation#latest_disability_evaluation
- LegacyDocket#age_of_n_oldest_genpop_priority_appeals
- OrganizationOnHoldTasksTab#name
- OrganizationTrackingTasksTab#column_names
- PendingIncompleteAndUncancelledTaskTimersQuery#call
- PowerOfAttorneyMapper
- Reporter#average
- Reporter#median
- Reporter#seconds_to_hms
- Reporter#percent
- SanitizedJsonConfiguration
- ScheduleHearingTaskPager#sorted_tasks
- UpdatePOAConcern
- VBMSCaseflowLogger#log
- LegacyDocket
UnusedParameters:
exclude:
- Docket#distribute_appeals
- HearingRequestDocket#distribute_appeals
### Directory specific configuration
# You can configure smells on a per-directory base.
# E.g. the classic Rails case: controllers smell of NestedIterators (see /docs/Nested-Iterators.md) and
# helpers smell of UtilityFunction (see docs/Utility-Function.md)
# Note that we only allow configuration on a directory level, not a file level, so all paths have to point to directories.
directories:
"app/controllers":
InstanceVariableAssumption:
enabled: false
"app/helpers":
UtilityFunction:
enabled: false
"app/jobs":
UtilityFunction:
enabled: false
"app/mailers":
InstanceVariableAssumption:
enabled: false
"db/seeds":
InstanceVariableAssumption:
enabled: false
TooManyInstanceVariables:
enabled: false
DataClump:
enabled: false
### Excluding directories
# Directories and files below will not be scanned at all
exclude_paths:
- db/migrate
- db/etl/migrate
- spec