Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALEFix is incompatible with isort < 5.7.0 #3941

Closed
jmsanders opened this issue Oct 14, 2021 · 2 comments
Closed

ALEFix is incompatible with isort < 5.7.0 #3941

jmsanders opened this issue Oct 14, 2021 · 2 comments
Labels

Comments

@jmsanders
Copy link

isort didn't introduce the --filename flag until 5.7.0:

#3815 introduces --filename which makes fixing incompatible with isort < 5.7.0

Perhaps ale should conditionally add the --filename flag based on the detected version of isort?

@jmsanders jmsanders added the bug label Oct 14, 2021
@hsanson
Copy link
Contributor

hsanson commented Oct 15, 2021

@jmsanders appreciated if you can verify this PR works for you: #3942

@jmsanders
Copy link
Author

Yep - works for me! Thanks for the quick fix!

@hsanson hsanson closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants