Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Automatic Oldest age in coloring #671

Open
DDDOH opened this issue Jan 11, 2024 · 8 comments
Open

Feature Request: Automatic Oldest age in coloring #671

DDDOH opened this issue Jan 11, 2024 · 8 comments

Comments

@DDDOH
Copy link

DDDOH commented Jan 11, 2024

The current Oldest age in coloring function is useful for me to quickly detect the most recent modification I made. But currently it only allows fixed setting of Oldest age in coloring. Is it possible to have an automatic option? Such as Oldest age in coloring is automatically set to the earliest commit of this file.

@GollyTicker
Copy link
Contributor

@DDDOH Hi, thanks for your idea. Original developer of the line authoring info here. It seems quite useful in my perspective as well.

However, there are some questions that come into my mind. When multiple files are opened side-by-side, do you want to see the same oldest-age color on all files - or have each file show it's own separate oldest age? When I developed the plugin, I was browsing many files, having the same color mean the same thing at all times was beneficial. However, given that you might be using files differently (perhaps longer files with a history to them) - you might benefit more from this kind of coloring.

Technically speaking, the implementation for this should be rather easy, as we only need minor modifications. But we'll also need to inject the oldest commit age into the gutter logic, as it doesn't know that information currently.

@Vinzent03 What do you think?

Regarding implementation. I really don't have time currently due to personal life reasons - however, I can give guidance for what is to be done where.

@DDDOH
Copy link
Author

DDDOH commented Mar 15, 2024

Thanks for your response. Personally I seldomly open multiple tabs together, so both two options work well for me. Maybe just use the option that is easier to implement?

@GollyTicker
Copy link
Contributor

@DDDOH

I thought about it all a bit. I think having each file with it's own oldest age coloring is less confusing. After all, if a new files is opened with an older age line - then the coloring of other unrelated opened files will also change - which doesn't make much sense.

So I think any implementation should treat each file independently.

Obviously, this option should be there in addition to what's already there and not replace it.

@DDDOH
Copy link
Author

DDDOH commented Mar 15, 2024

@GollyTicker That makes sense. It could be a little bit weird if the coloring keeps changing when we open and close files.

@GollyTicker
Copy link
Contributor

@DDDOH .

Cool! Would you be interested in implementing this given some guidance? 😊

@DDDOH
Copy link
Author

DDDOH commented Mar 17, 2024

@GollyTicker Sure I am wiling to offer some help if other maintainers are busy at this time. However I am new to css and related tech required by obsidian plugins, and is kinda busy for this month. I will let you know once I am available on this matter!

@GollyTicker
Copy link
Contributor

@DDDOH Cool! Just hit me here and I can give you a small intro on where and how to get started 😊

@GollyTicker
Copy link
Contributor

@DDDOH ping 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants