Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set root folder for plugin #75

Closed
parliament718 opened this issue Jun 4, 2020 · 5 comments
Closed

Set root folder for plugin #75

parliament718 opened this issue Jun 4, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@parliament718
Copy link

parliament718 commented Jun 4, 2020

Is there a away to set the root folder for the deno code? Currently it seems like it can only be limited to a workspace but my workspace contains the following:

workspace
|--client (Angular app)
|--server (deno app)

Enabling the plugin globally or for the workspace results in me geting all sorts of errors in my Angular project (bad imports without extensions).

Multiple workspaces in a single window is not yet a feature in vscode so I have to use multiple vscode windows.

Is there a way to avoid this?

@garysb
Copy link

garysb commented Jun 7, 2020

This is extremely annoying for me. We too have multiple angular clients and then have multiple lambda functions on the server, some written in typescript, some in javascript, and now some in typescript with Deno.

What would be helpful is if we could have the Deno extension only be enabled for the parts that are actually Deno without having to disable the extension on every project that is NOT Deno. So basically, globally disabled by default and explicitly enabled for a directory within my workspace.

@Ciantic
Copy link

Ciantic commented Jun 22, 2020

Even if deno never had a configuration file (because getting rid of package.json was one of the goals), I could see a dummy file for IDE support being useful.

If some dir had a file like .denoproject then the IDE could deduce it needs to enable Deno's typescript plugin for files inside that directory:

somedir/.denoproject
otherdir/yournode app

I also find it a bit annoying that Deno plugin is enabled by default, of course I disabled it by default because most projects at the moment are not Deno projects. However if there was a dummy file that wouldn't be a problem, because the extension could be made to trigger when it sees that file.

@Flaque
Copy link
Contributor

Flaque commented Jun 23, 2020

See #92

@bartlomieju bartlomieju added the enhancement New feature or request label Aug 4, 2020
@CGQAQ
Copy link
Contributor

CGQAQ commented Sep 9, 2020

#194 included

@lucacasonato
Copy link
Member

Closing in favor of #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants