Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated APIs in binding.cc #1478

Open
mmastrac opened this issue May 14, 2024 · 0 comments · May be fixed by #1488
Open

Use of deprecated APIs in binding.cc #1478

mmastrac opened this issue May 14, 2024 · 0 comments · May be fixed by #1488
Assignees
@devsnek @bartlomieju

Comments

@mmastrac
Copy link
Contributor

mmastrac commented May 14, 2024 •
edited

When moving to 12.6, we bumped into a large number of deprecated APIs.

To work around it, the entire binding file is now ignoring deprecated APIs, but these will need to be bumped to the replacement APIs.

  ../../../../src/binding.cc:1225:24: error: 'SetAccessor' is deprecated: Use SetNativeDataProperty instead [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:1239:35: error: 'NamedPropertyHandlerConfiguration' is deprecated: Provide interceptor callbacks with new signatures instead (NamedPropertyXxxCallback) [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:1253:35: error: 'IndexedPropertyHandlerConfiguration' is deprecated: Provide interceptor callbacks with new signatures instead (IndexedPropertyXxxCallbackV2) [-Werror,-Wdeprecated-declarations]
  ../../../../src/binding.cc:3739:11: error: 'WrapperDescriptor' is deprecated: WrapperDescriptor is deprecated, see crbug.com/338411141. [-Werror,-Wdeprecated-declarations]
  ../../../../v8/include/v8-cppgc.h:90:3: note: 'CppHeapCreateParams' has been explicitly marked deprecated here
This was referenced May 14, 2024
Merged
Merged
bartlomieju added a commit that referenced this issue May 15, 2024
@bartlomieju
chore: Update use of deprecated APIs (#1481)
cf3f19c 
This commit updates APIs related to named and indexed property
handlers to not use deprecated V8 APIs. Main change is the change
of return value in callbacks that now requires to return v8::Intercepted enum.

Towards #1478
@devsnek devsnek self-assigned this May 22, 2024
@devsnek devsnek linked a pull request May 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devsnek devsnek

@bartlomieju bartlomieju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove deprecated cppgc embedder api and use new wrap api denoland/rusty_v8
3 participants
@mmastrac @devsnek @bartlomieju