Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: stabilize std/internal #4739

Closed
2 tasks done
iuioiua opened this issue May 15, 2024 · 3 comments · Fixed by #4741
Closed
2 tasks done

proposal: stabilize std/internal #4739

iuioiua opened this issue May 15, 2024 · 3 comments · Fixed by #4741

Comments

@iuioiua
Copy link
Collaborator

iuioiua commented May 15, 2024

Requirements:

  • 100% documented, passing deno doc --lint checks and adhering to the documentation guidelines.
  • Maximum possible test coverage

This is to unblock dependents from being stabilized, so we're skipping 1.0.0-rc.1 and going straight to 1.0.0.

Towards #4600
This was referenced May 15, 2024
Open
Merged
Merged
@timreichen
Copy link
Contributor

Std/internal has diff() and diffstr(). Is there a reason why they are abbreviated and not written out?

@iuioiua
Copy link
Collaborator Author

iuioiua commented May 17, 2024

What a "diff" is is common knowledge. I don't think anyone's had any issues understanding it, nor do I think anyone will. If we do, we can reconsider, but it's fine.

@timreichen
Copy link
Contributor

What a "diff" is is common knowledge. I don't think anyone's had any issues understanding it, nor do I think anyone will. If we do, we can reconsider, but it's fine.

Ok, but there are datetime/difference.ts and semver/difference.ts which are written out, and commonly WebApis do not use abbreviations (Set.prototype.difference(), Set.prototype.symmetricDifference()). Just thinking about consistency across multiple modules and apis.

@kt3k kt3k mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(internal): release internal@1.0.0 denoland/deno_std
2 participants
@timreichen @iuioiua