Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/asserts - Handle __proto__ property #2954

Closed
dsherret opened this issue Nov 28, 2022 · 4 comments
Closed

testing/asserts - Handle __proto__ property #2954

dsherret opened this issue Nov 28, 2022 · 4 comments
Labels
help wanted Extra attention is needed suggestion a suggestion yet to be agreed testing

Comments

@dsherret
Copy link
Member

We might have a readonly __proto__ property in Deno (denoland/deno#16775) and it seems like assertEquals does not handle it.

See here for more details: denoland/dnt#235

@dsherret dsherret added testing suggestion a suggestion yet to be agreed labels Nov 28, 2022
@dsherret dsherret added the help wanted Extra attention is needed label Nov 28, 2022
@schwarzkopfb
Copy link
Contributor

@kt3k
Copy link
Member

kt3k commented Dec 20, 2022

The root issue in the use case in dnt seems resolved by adding NODE_OPTIONS='--disable-proto=delete' in dnt execution (which removes __proto__ in Node.js and make Deno test cases work similarly in Node.js). ref: KnorpelSenf/oson@0fe5862

I think we can recommend the above as the solution to this problem.

@KnorpelSenf
Copy link

I think we can recommend the above as the solution to this problem.

Yes.

I originally reported denoland/dnt#235 and I can confirm that KnorpelSenf/oson@0fe5862 works well.

@kt3k
Copy link
Member

kt3k commented Dec 21, 2022

@KnorpelSenf Thanks for the confirmation!

@kt3k kt3k closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed suggestion a suggestion yet to be agreed testing
Projects
None yet
Development

No branches or pull requests

4 participants