perf: make module analysis async #477
Conversation
There was a problem hiding this comment.
The code in here is pretty crazy, but it was initially crazy. We should spend some time cleaning this up in the future.
There was a problem hiding this comment.
Can you jot down some notes in an issue about what's crazy and how it could be improved? This might be a good task in the future for someone getting to know this codebase.
There was a problem hiding this comment.
By "crazy" I just mean messy. Someone needs to go through and clean it up sometime.
There was a problem hiding this comment.
I agree, feels like it should be split into multiple smaller modules.
|
maybe this should rather be "perf: make module analysis async" |
dsherret
changed the title
| pub(crate) enum ModuleSourceAndInfo { | ||
| Json { | ||
| specifier: ModuleSpecifier, | ||
| source: Arc<str>, | ||
| }, | ||
| Js { | ||
| specifier: ModuleSpecifier, | ||
| media_type: MediaType, | ||
| source: Arc<str>, | ||
| maybe_headers: Option<HashMap<String, String>>, | ||
| module_info: Box<ModuleInfo>, | ||
| }, | ||
| } |
There was a problem hiding this comment.
I'm surprised you don't get a warning about enum variants big size difference
There was a problem hiding this comment.
I agree, feels like it should be split into multiple smaller modules.
This allows us to parse source files in parallel for the first run:
Same speed on second run:
Closes #474