Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should deno_emit output ignore comments like deno bundle? #106

Open
yacinehmito opened this issue Apr 26, 2023 · 1 comment
Open

Should deno_emit output ignore comments like deno bundle? #106

yacinehmito opened this issue Apr 26, 2023 · 1 comment

Comments

@yacinehmito
Copy link
Contributor

I am in the process of back-porting tests from deno bundle to deno_emit, and I found that we explicitly ensure that the output of deno bundle contains the following:

// deno-fmt-ignore-file
// deno-lint-ignore-file
// This code was bundled using `deno bundle` and it's not recommended to edit it manually

Is it desirable to implement something similar for deno_emit? If not, why? If so, should that be configurable?

@dsherret
Copy link
Member

dsherret commented May 4, 2023

I think that can be added by people if they want it in the output. That said, probably it creates some complications with source maps so maybe it should be handled by this crate? Or maybe it can be configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants