Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsync/fdatasync running on main thread #8613

Closed
jannes opened this issue Dec 4, 2020 · 3 comments
Closed

fsync/fdatasync running on main thread #8613

jannes opened this issue Dec 4, 2020 · 3 comments

Comments

@jannes
Copy link

jannes commented Dec 4, 2020

I recently wrote a few scripts to benchmark different sizes for the tokio pool
that is used for running blocking disk IO calls such as write, read.
I noticed that fsync/fdatasync system calls are made from the main thread.

As these are blocking calls, I believe they should also be executed by the Tokio pool.
Otherwise for workloads that make heavy use of these system calls
the main thread will be constantly blocked.

@bartlomieju
Copy link
Member

CC @caspervonb

Related #7400
Blocked by #7984

@caspervonb
Copy link
Contributor

Kind-of blocked on #8416 (altho not impossible, tedious to make this async with the current resource table).

@bartlomieju
Copy link
Member

Let's continue this topic as part of #7400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants